Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from Flask's HTTP server #15

Open
tslmy opened this issue Jan 21, 2021 · 2 comments
Open

Migrate away from Flask's HTTP server #15

tslmy opened this issue Jan 21, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@tslmy
Copy link

tslmy commented Jan 21, 2021

First of all -- Thanks for putting together this repo and hosting these images.

Currently, the Docker images built by this repo is using Flask as a HTTP server:

mozillatts_1  |  * Serving Flask app "mozillatts" (lazy loading)
mozillatts_1  |  * Environment: production
mozillatts_1  |    WARNING: This is a development server. Do not use it in a production deployment.
mozillatts_1  |    Use a production WSGI server instead.

As the official documentation indicates, Flask’s built-in server is not suitable for production as it doesn’t scale well. This goes against the philosophy of containerization in the first place and is subject to security issues.

Kindly consider migrate to other HTTP server implementations such as gunicorn.

@synesthesiam synesthesiam added the enhancement New feature or request label Feb 17, 2021
@laundmo
Copy link

laundmo commented May 6, 2021

i personally like and recommend using the tiangolo meinheld/gunicorn image that can be found here
https://github.com/tiangolo/meinheld-gunicorn-flask-docker

@synesthesiam
Copy link
Owner

I've migrated to Coqui TTS, the successor to Mozilla TTS. The new Docker images are available here: https://github.com/synesthesiam/coqui-docker/ (still using the default Flask server, unfortunately).

My Larynx TTS project is using hypercorn, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants