Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Adding flow step to API provider based integration yields error #3694

Closed
zregvart opened this issue Sep 28, 2018 · 7 comments · Fixed by #3699
Closed

Adding flow step to API provider based integration yields error #3694

zregvart opened this issue Sep 28, 2018 · 7 comments · Fixed by #3699
Assignees
Labels
cat/bug A bug which needs fixing closed/verified Used by QE to indicate that verified the issue group/ui User interface SPA, talking to the REST backend

Comments

@zregvart
Copy link
Member

This is a...


[ ] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Documentation issue or request

The problem

I can't seem to edit a flow to add a step to it. The browser console emits an error:

main.bd08e7b5ad2ce0b417ba.js:1 TypeError: Cannot read property 'action' of undefined
    at n.ngOnChanges (11.bb2047dff352bcbffb47.js:1)
    at main.bd08e7b5ad2ce0b417ba.js:1
    at main.bd08e7b5ad2ce0b417ba.js:1
    at $a (main.bd08e7b5ad2ce0b417ba.js:1)
    at Sl (main.bd08e7b5ad2ce0b417ba.js:1)
    at Object.updateDirectives (11.bb2047dff352bcbffb47.js:1)
    at Object.updateDirectives (main.bd08e7b5ad2ce0b417ba.js:1)
    at Xa (main.bd08e7b5ad2ce0b417ba.js:1)
    at il (main.bd08e7b5ad2ce0b417ba.js:1)
    at rl (main.bd08e7b5ad2ce0b417ba.js:1)

Expected behavior

I should be able to edit and add steps as needed to the flow.

Screenshot

peek 2018-09-28 12-34

Request and Response Data

API Endpoints and Schemas

I only see GET requests to /api/v1/integrations/i-LNUix7uR6BhTm3sXS83z and /api/v1/monitoring/integrations/i-LNUix7uR6BhTm3sXS83z, probably unrelated.

Tasks involved / Steps to Reproduce

  1. Create API provider based integration
  2. Try to edit one of the flows to add a step

console-log.txt

@zregvart zregvart added cat/bug A bug which needs fixing group/ui User interface SPA, talking to the REST backend labels Sep 28, 2018
@pure-bot pure-bot bot added notif/triage The issue needs triage. Applied automatically to all new issues. progress/inbox labels Sep 28, 2018
@oscerd
Copy link
Collaborator

oscerd commented Sep 28, 2018

I believe the set-body extension currently don't work if you compile with 1.5-SNAPSHOT syndesis dependencies.

@zregvart
Copy link
Member Author

Perhaps it's an issue with Set Body extension, I can add the mapper to the POST request (one that has datashape on the start and end shapes)

@zregvart zregvart added group/extension Tools for developing Syndesis extensions and removed group/ui User interface SPA, talking to the REST backend labels Sep 28, 2018
@oscerd
Copy link
Collaborator

oscerd commented Sep 28, 2018

yes, the problem with setBody it's documented here: syndesisio/syndesis-extensions#69

Also we need to align the extensions to what we have in Syndesis.

@gashcrumb gashcrumb self-assigned this Sep 28, 2018
@gashcrumb
Copy link
Contributor

Page shouldn't be throwing that error anyways, will definitely fix that.

@gashcrumb gashcrumb added group/ui User interface SPA, talking to the REST backend and removed notif/triage The issue needs triage. Applied automatically to all new issues. labels Sep 28, 2018
@gashcrumb
Copy link
Contributor

Hmm, actually has nothing to do with the API provider or the set body extension, it occurs when the start connection doesn't have a data shape like the timer connection, so just a UI bug.

@gashcrumb gashcrumb removed the group/extension Tools for developing Syndesis extensions label Sep 28, 2018
@pure-bot pure-bot bot closed this as completed in #3699 Sep 28, 2018
@pure-bot pure-bot bot locked as resolved and limited conversation to collaborators Sep 28, 2018
@pure-bot pure-bot bot reopened this Sep 28, 2018
@pure-bot pure-bot bot unlocked this conversation Sep 28, 2018
@tplevko
Copy link
Contributor

tplevko commented Oct 2, 2018

@mmajerni please verify the fix

@mmajerni
Copy link

mmajerni commented Oct 8, 2018

Verified by QE

@mmajerni mmajerni closed this as completed Oct 8, 2018
@pure-bot pure-bot bot removed the progress/done label Oct 8, 2018
@tplevko tplevko added the closed/verified Used by QE to indicate that verified the issue label Oct 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cat/bug A bug which needs fixing closed/verified Used by QE to indicate that verified the issue group/ui User interface SPA, talking to the REST backend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants