Skip to content
This repository has been archived by the owner on Nov 27, 2017. It is now read-only.

Reset ChangeDetectorStrategy to ensure data refresh on Syndesis UI #1185

Open
6 tasks
deeleman opened this issue Nov 7, 2017 · 1 comment
Open
6 tasks

Comments

@deeleman
Copy link
Contributor

deeleman commented Nov 7, 2017

For some reason the root application component has its ChangeDetectionStrategy set to OnPush, which invalidates automated change detection beyond the first OnCheck execution for all child components throughout the app.

This entails that no component will update unless a reference change occurs on any of its bindings, which is unlikely when the binding is an array or a non primitive type.

The goal of this issue is to reset the ChangeDetectionStrategy setting and remove, if possible, all manual calls to the change detection provider to streamline code and ensure components update seamlessly.

  • Reset application's ChangeDetectionStrategyto default mode.
  • Remove manual calls to detectChanges() whereas possible (inc. associated try/catch).
  • Remove manual calls to markForCheck() whereas possible.
  • Set DerpPipe as Pure.
  • Set ObjectPropertyFilterPipe as Pure.
  • Set StepVisiblePipe as Pure.
@deeleman deeleman self-assigned this Nov 7, 2017
@deeleman deeleman added this to the Sprint 20 milestone Nov 7, 2017
@deeleman deeleman changed the title Reset ChangeDetectorStrategy to Default for the whole frontend app Reset ChangeDetectorStrategy to ensure data refresh on Syndesis UI Nov 7, 2017
@gashcrumb
Copy link
Contributor

I knew I had an issue open for this -> #912

I'll close that old one and we can track this work in this new issue...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants