Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't redisplay and font locking while doing evil-escape #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kiennq
Copy link

@kiennq kiennq commented Jul 4, 2019

This should help resolve #84.
Also doing redisplay and font locking (due to read-event) in evil-escape is annoying since redisplay can slow down Emacs, and makes it easily to miss second key pressed.

@Atrus7
Copy link

Atrus7 commented Jan 12, 2020

I have the same issue. Getting "fd" into my buffer instead of escaping is a chief annoyance and immediately sets me into debugging.

Can we land this?

@neeasade
Copy link

neeasade commented May 2, 2020

@kiennq thank you!! this modification makes typing much smoother when using evil escape (I narrowed down stuff by turning off font-locking in an org mode buffer and evil-escape was my typing latency culprit)

@kiennq kiennq force-pushed the bug/slow-redisplay branch from 02bf0d7 to 17d83aa Compare May 2, 2020 16:09
hlissner added a commit to hlissner/evil-escape that referenced this pull request May 2, 2020
Fixes syl20bnr#84

Co-authored-by: kiennq <[email protected]>
hlissner added a commit to doomemacs/doomemacs that referenced this pull request May 2, 2020
@kiennq kiennq force-pushed the bug/slow-redisplay branch from 17d83aa to 5cc4959 Compare May 13, 2020 12:30
@safijari
Copy link

safijari commented Jul 1, 2021

Is there any reason to not merge this?

tarsius pushed a commit to emacsorphanage/evil-escape that referenced this pull request Nov 22, 2023
This merges syl20bnr#91.
@hlissner merged this into his fork, so I assume it is good.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

evil-escape-pre-command-hook slowing everything down
4 participants