Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run documentation notebooks on CI #6231

Open
nilsvu opened this issue Aug 19, 2024 · 0 comments
Open

Run documentation notebooks on CI #6231

nilsvu opened this issue Aug 19, 2024 · 0 comments

Comments

@nilsvu
Copy link
Member

nilsvu commented Aug 19, 2024

To make sure that notebooks in docs/ keep working, we should run them on CI. They need Pybindings compiled, so we either compile those in the docs CI job, or run the notebooks in one of the unit test workflows. To have the updated output in the notebooks show up in the docs it would be easier to run them in the docs CI job.
Another consideration is sample data that the notebooks need. We either make sure they run fast and without any sample data, or we allow them to use external data in which case they would be harder to test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant