Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server does not end all progress tokens #802

Open
alcarney opened this issue Apr 29, 2024 · 2 comments
Open

Server does not end all progress tokens #802

alcarney opened this issue Apr 29, 2024 · 2 comments
Labels
bug Something isn't working lsp Issues that relate to the language server
Milestone
1.0

Comments

@alcarney
Copy link
Member

Expected behavior

After a build had failed VSCode was still showing the window/workDoneProgress spinner, even though no build was in progress.

Actual behavior

The server should ensure the progress is marked as complete, even when there's an error

Log output

No response

(Optional) Settings from conf.py

No response
@alcarney alcarney added bug Something isn't working lsp Issues that relate to the language server labels Apr 29, 2024
@alcarney alcarney added this to the 1.0 milestone Apr 29, 2024
@alcarney alcarney added this to Esbonio Apr 29, 2024
@github-project-automation github-project-automation bot moved this to Todo in Esbonio Apr 29, 2024
@alcarney
Copy link
Member Author

Not sure if it's necessarily build failures, or if it's many builds triggered in succession?
After actually using the pre-release a bit more recently, I often see the progress spinner when it's not actually building...

@alcarney alcarney changed the title Server does not end progress when the build fails Server does not end all progress tokens Aug 20, 2024
@alcarney
Copy link
Member Author

alcarney commented Aug 20, 2024 •
edited
Loading

It doesn't appear to be related to build errors at all. The server's progress token tracking needs improvement, it's starting tokens multiple tokens but loses track of some so they never get closed.

$ lsp-devtools record --include-method '$/progress' -f '[{.params.token}][{.params.value.kind}]: {.params.value.message}'
20:02:44 SERVER [e34590b7-6744-4176-a4d7-12927fbb4bbe][report]: writing output...                                    
20:02:44 SERVER [e34590b7-6744-4176-a4d7-12927fbb4bbe][report]: reading sources...                                   
20:02:44 SERVER [e34590b7-6744-4176-a4d7-12927fbb4bbe][report]: pickling environment                                 
20:02:45 SERVER [e34590b7-6744-4176-a4d7-12927fbb4bbe][report]: checking consistency                                 
20:02:45 SERVER [e34590b7-6744-4176-a4d7-12927fbb4bbe][report]: preparing documents                                  
20:02:45 SERVER [e34590b7-6744-4176-a4d7-12927fbb4bbe][report]: copying assets                                       
20:02:45 SERVER [e34590b7-6744-4176-a4d7-12927fbb4bbe][report]: copying static files                                 
20:02:45 SERVER [e34590b7-6744-4176-a4d7-12927fbb4bbe][report]: copying extra files                                  
20:02:45 SERVER [e34590b7-6744-4176-a4d7-12927fbb4bbe][report]: writing output...                                    
20:02:46 SERVER [e34590b7-6744-4176-a4d7-12927fbb4bbe][report]: generating indices                                   
20:02:46 SERVER [e34590b7-6744-4176-a4d7-12927fbb4bbe][report]: writing additional pages                             
20:02:46 SERVER [e34590b7-6744-4176-a4d7-12927fbb4bbe][report]: dumping search index in English (code: en)           
20:02:46 SERVER [e34590b7-6744-4176-a4d7-12927fbb4bbe][report]: dumping object inventory                             
20:02:46 SERVER [e34590b7-6744-4176-a4d7-12927fbb4bbe][end]: Finished                                                
20:02:49 SERVER [acf95633-9c6a-4b2a-86e2-62955dfa389e][report]: writing output...   <-- This token is never closed,                                 
20:02:49 SERVER [acf95633-9c6a-4b2a-86e2-62955dfa389e][report]: reading sources...  <-- leaving a persistent spinner in the client!
20:02:50 SERVER [6128c05d-9289-447c-9281-b90ec4819f31][report]: pickling environment                                 
20:02:50 SERVER [6128c05d-9289-447c-9281-b90ec4819f31][report]: checking consistency                                 
20:02:50 SERVER [6128c05d-9289-447c-9281-b90ec4819f31][report]: preparing documents                                  
20:02:50 SERVER [6128c05d-9289-447c-9281-b90ec4819f31][report]: copying assets                                       
20:02:50 SERVER [6128c05d-9289-447c-9281-b90ec4819f31][report]: copying static files                                 
20:02:50 SERVER [6128c05d-9289-447c-9281-b90ec4819f31][report]: copying extra files                                  
20:02:50 SERVER [6128c05d-9289-447c-9281-b90ec4819f31][report]: writing output...                                    
20:02:51 SERVER [6128c05d-9289-447c-9281-b90ec4819f31][report]: generating indices                                   
20:02:51 SERVER [6128c05d-9289-447c-9281-b90ec4819f31][report]: writing additional pages                             
20:02:51 SERVER [6128c05d-9289-447c-9281-b90ec4819f31][report]: dumping search index in English (code: en)           
20:02:51 SERVER [6128c05d-9289-447c-9281-b90ec4819f31][report]: dumping object inventory                             
20:02:51 SERVER [6128c05d-9289-447c-9281-b90ec4819f31][end]: Finished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working lsp Issues that relate to the language server
Projects
Esbonio
Status: Todo
Milestone
1.0
Development

No branches or pull requests
1 participant
@alcarney