You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the Vertex class (used for bundled properties in the BGL search methods) holds a subset of the information needed by the search methods (distance and color). Other properties, namely the vertex predecessor, is being managed outside the graph.
/** @brief Search status "color" of the vertex: visited, opened, unvisited. Assigned by the graph algorithm at
* search-time */
ColorT color{ 0 };
};
For clarity, it seems like the graph should either:
manage all the vertex properties required for the search in the graph
Pros:
Bundled properties are somewhat easier to manage in the graphs
Cons:
Some fields of the Vertex class need to be populated by the solver build method and should be held constant during the search (sample and rung_idx), and other methods will be filled out by the search method (color, distance, etc.). This is somewhat confusing and prone to error
all of those properties should be managed outside of the search.
Pros:
The Vertex class can be composed of only "read-only" members that get populated by the solver build method, which would reduce ambiguity about the class
Cons:
The containers for the vertex properties must be stored/maintained inside the solver class
The property containers would need to be passed to the graph serialization functions
The text was updated successfully, but these errors were encountered:
Currently the
Vertex
class (used for bundled properties in the BGL search methods) holds a subset of the information needed by the search methods (distance and color). Other properties, namely the vertex predecessor, is being managed outside the graph.descartes_light/descartes_light/solvers/include/descartes_light/solvers/bgl/boost_graph_types.h
Lines 36 to 49 in d56038b
For clarity, it seems like the graph should either:
Vertex
class need to be populated by the solverbuild
method and should be held constant during the search (sample
andrung_idx
), and other methods will be filled out by thesearch
method (color
,distance
, etc.). This is somewhat confusing and prone to errorVertex
class can be composed of only "read-only" members that get populated by the solverbuild
method, which would reduce ambiguity about the classThe text was updated successfully, but these errors were encountered: