Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inadequate Docker Registry documentation #138

Open
mhaeuser opened this issue Mar 10, 2021 · 0 comments
Open

Inadequate Docker Registry documentation #138

mhaeuser opened this issue Mar 10, 2021 · 0 comments

Comments

@mhaeuser
Copy link

The following refers to the documentation "Installation - Docker - With a Private Registry" (available at https://github.com/swri-robotics/bag-database/blob/master/docs/installation/docker/with-a-private-registry.md, and https://swri-robotics.github.io/bag-database/installation/docker/with-a-private-registry).

  1. Ports for the Docker registry service registry are declared with ports, which exposes them to the host [1]. This is obviously a security issue and should not be recommended anywhere at all. More so, to not let users carelessly export unauthenticated HTTP registries, I believe recommending running two registries - one properly secured for general usage, and one unsecured as service exclusive to bag-db. Only the general registry must be "writable" (as I understand, nothing in bag-database will ever try to submit new images?) as otherwise write conflicts are not guaranteed to be avoided.
  2. The registry service is not part of the bagdb network. This is incompatible with the usage of registry:5000 later in the same documentation, as the registry host name is not published in any other fashion (and no other container is part of the default network).

[1] https://docs.docker.com/compose/compose-file/compose-file-v3/#ports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant