Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vscodes TypeScript Language Server to Recommend Log Points #47

Open
swissmanu opened this issue May 15, 2021 · 1 comment
Open

Use vscodes TypeScript Language Server to Recommend Log Points #47

swissmanu opened this issue May 15, 2021 · 1 comment
Assignees
Labels
improvement This issue describes the improvement of an existing feature

Comments

@swissmanu
Copy link
Owner

Suggestion

To determine the type of a token in the source code, the extension uses a fragile combination of parsing the code with the TypeScript compiler and requesting hovers for relevant AST nodes via the vscode.executeHoverProvider vscode command.

With this change, we would use the TS language server of vscode to determine the type of a token instead.

Advantages

  • No overhead of additional TS parser runs
  • Type determination for token is not depending from the hover API anymore. With this, it becomes more robust.

Risks

@swissmanu swissmanu added the improvement This issue describes the improvement of an existing feature label May 15, 2021
@swissmanu swissmanu added this to the v1.0.0 milestone Sep 23, 2021
@swissmanu swissmanu self-assigned this Sep 30, 2021
@swissmanu
Copy link
Owner Author

This might be important on the long run, but the operator log point recommender would not really benefit from it. Removing from milestone v1.0.0.

@swissmanu swissmanu removed this from the v1.0.0 milestone Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue describes the improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant