Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current value for map downlinks from a plane is always absent #65

Open
DobromirM opened this issue Sep 30, 2021 · 1 comment
Open

Current value for map downlinks from a plane is always absent #65

DobromirM opened this issue Sep 30, 2021 · 1 comment
Labels
C-bug Category: bug

Comments

@DobromirM
Copy link
Member

If a map downlink is created from a PlaneContext the current value on didUpdate is always Value.absent().

Example:

BasicPlane.java

public class BasicPlane extends AbstractPlane {

  @SwimRoute("/unit/:id")
  AgentRoute<UnitAgent> unitAgentType;

  public static void main(String[] args) {
    final Kernel kernel = ServerLoader.loadServer();
    final ActorSpace space = (ActorSpace) kernel.getSpace("basic");

    kernel.start();
    System.out.println("Running Basic server...");
    kernel.run();

    space.command("/unit/foo", "wakeup", Value.absent());
  }

  @Override
  public void didStart() {
    super.didStart();

    //Plane downlink
    context.downlinkMap()
            .keyForm(Form.forString()).valueForm(Form.forInteger())
            .nodeUri("/unit/foo").laneUri("shoppingCart")
            .didUpdate((key, newValue, oldValue) -> {
              System.out.println("plane: " + key + " count changed to " + newValue + " from " + oldValue);
            })
            .open();
  }
}

UnitAgent.java

public class UnitAgent extends AbstractAgent {

  @SwimLane("shoppingCart")
  MapLane<String, Integer> shoppingCart = this.<String, Integer>mapLane()
      .didUpdate((key, newValue, oldValue) -> {
          System.out.println("agent: " + key + " count changed to " + newValue + " from " + oldValue);
      });

  @SwimLane("addItem")
  CommandLane<String> publish = this.<String>commandLane()
      .onCommand(msg -> {
        final int n = this.shoppingCart.getOrDefault(msg, 0) + 1;
        this.shoppingCart.put(msg, n);
      });

}

Input:

@command(node:"/unit/foo", lane:"addItem")"foo"
@command(node:"/unit/foo", lane:"addItem")"foo"
@command(node:"/unit/foo", lane:"addItem")"foo"

Output:

agent: foo count changed to 1 from 0
plane: foo count changed to 1 from 0
agent: foo count changed to 2 from 1
plane: foo count changed to 2 from 0
agent: foo count changed to 3 from 2
plane: foo count changed to 3 from 0

(The plane downlink messages should match the agent downlink messages)

@DobromirM DobromirM added the C-bug Category: bug label Sep 30, 2021
@DobromirM
Copy link
Member Author

The same problem does NOT exist for value downlinks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug
Projects
None yet
Development

No branches or pull requests

1 participant