Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for changes in the number of speeches #49

Open
MansMeg opened this issue Oct 17, 2024 · 3 comments
Open

Test for changes in the number of speeches #49

MansMeg opened this issue Oct 17, 2024 · 3 comments

Comments

@MansMeg
Copy link
Contributor

MansMeg commented Oct 17, 2024

We should test that the number of speeches doesn't change between versions of the coprus.

Or rather, if there is a change, we need to update the unit test simultaneously to be very defensive.

@fredrik1984
Copy link
Contributor

Good idea. The number of speeches is likely to change if the segmentation of speeches improves. For example, better segmentation might lead to more annotated speeches (from one incorrectly annotated speech to several), or fewer speeches.

@MansMeg
Copy link
Contributor Author

MansMeg commented Oct 17, 2024

Yes. I think that is reasonable. But then we will change the unit test at the same time. But if we don't, e.g. change the note/seg classifications, the no of speeches should remain the same. Right?

@BobBorges
Copy link
Contributor

The number of speeches should stay the same --- if we accept @ninpnin 's definition so long as no intros change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants