Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary file - indexbase.html #392

Open
aryanpingle opened this issue Sep 21, 2022 · 0 comments
Open

Unnecessary file - indexbase.html #392

aryanpingle opened this issue Sep 21, 2022 · 0 comments

Comments

@aryanpingle
Copy link
Member

indexbase.html does effectively the same thing as base.html, but for users who aren't signed in yet. The file should be deleted, and anything dependent on it should be refactored to use base.html.

WHY

Pretty soon we'll have to do some homepage redesigns, and we'll definitely run into errors because we'll forget about this extra file.
It's already affecting development of "homepage pages" like 'contact us' and 'developers', because they sometimes extend into indexbase.html.

Possible solution is to send a user-authenticated flag to base.html so that it displays the right thing for the right visitor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant