Add a safearea around all the screens #264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAicewizard
added
the
chore
DeD1rk
force-pushed
the
master
branch
4 times, most recently
from
7131265 to
658f9f4
Compare
DeD1rk
reviewed
Nov 2, 2022
DeD1rk
reviewed
Nov 2, 2022
|
CI can't deploy from a fork, so I'll merge into a different branch first. |
|
Or actually, I have no idea what I did but #281 should be able to build... |
|
Ok that's kinda annoying that it cant do that. Should I just use branches on this repo? |
Yup, I'll doouble-check that you have write access. |
|
https://stackoverflow.com/questions/52105557/how-to-remove-automatic-safearea-from-listview Tldr: listviews include the required padding themselves, unless we specify it ourselves, so we only need to modify the padding we set to take into account the mediaquery |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a SafeArea around all the screens, ensuring enough space to avoid problems with the notches and other device/OS specific areas.