Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of operational webhooks server name #1138

Open
boothj5 opened this issue Dec 6, 2023 · 0 comments
Open

Handling of operational webhooks server name #1138

boothj5 opened this issue Dec 6, 2023 · 0 comments
Labels
server Issues regarding the server component

Comments

@boothj5
Copy link
Contributor

boothj5 commented Dec 6, 2023

After having an issue running local operational webhooks (see the following pull request #1137) it looks as though handling the server url could do with a little more validation.

Comments from @tasn in Slack chat:

"we should probably have validation (or rather URL sanitization?) to fix this class of issues going forward."

"we should have also checked if it's a 404 because the org is not found or if it's just a bad path, so we should have improved that too."

The following discussion also has some more information: #1125

@tasn tasn added good first issue server Issues regarding the server component labels Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server Issues regarding the server component
Projects
None yet
Development

No branches or pull requests

3 participants