Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release coordination #148

Open
svenstaro opened this issue Jan 19, 2025 · 4 comments
Open

New release coordination #148

svenstaro opened this issue Jan 19, 2025 · 4 comments

Comments

@svenstaro
Copy link
Owner

I'd like to make a new release since there's been so much stuff in the mean time. Is there anything else you want to put into the next release @finnbear? Feel free to edit this and add a checklist with items.

@finnbear
Copy link
Collaborator

Cool! I want to investigate the NaN/infinity issue for a few more hours, some time in the next couple days. I agree there should be a new release soon :)

@svenstaro
Copy link
Owner Author

The benchmarks section in the README is hopelessly out of date by now. We should either remove it or put new benchmarks there. However, do the particular numbers really matter? Perhaps we can provide an indication of roughly how much benefit each feature has and leave it at that. If people are interested at how fast the benchmarks are on their machines, they can easily run it.

@finnbear
Copy link
Collaborator

IMO the raw numbers don't matter. I'm in favor of removing them, but keeping the qualitative documentation about the relative speeds of different features.

I'm also thinking about adding a phase diagram (per traversal type) to the README:

  • x axis is number of triangles (logarithmic 1-10,000)
  • y axis is number of rays (logarithmic 1-10,000)
  • color/z axis is speedup coefficient comparing:
    • building BVH with x triangles and traversing with y rays
    • brute force y rays against x triangles

@svenstaro
Copy link
Owner Author

Sounds like a good idea. A phase diagram might be overkill. How about a bunch of easier to read triangles vs time diagrams? You can also be fancy if you want, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants