Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes combination recipe (base pr) #403

Merged
merged 23 commits into from
May 24, 2024

Conversation

rishabhpoddar
Copy link
Contributor

@rishabhpoddar rishabhpoddar commented Apr 9, 2024

Related issues

Test Plan

  • Changes to test to use separate recipes in all tests that had them as combination.

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens/constants.go
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In supertokens/constants.go > version variable
  • Had installed and ran the pre-commit hook
  • If new thirdparty provider is added,
    • update switch statement in recipe/thirdparty/providers/config_utils.go file, createProvider function.
    • add an icon on the user management dashboard.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If access token structure has changed
    • Modified test in session/accessTokenVersions_test.go to account for any new claims that are optional or omitted by the core

Remaining TODOs for this PR

  • Search for all places for thirdpartyemailpassword and thirdpartypasswordless and make sure they don't exist
  • Test dashboard
  • if input rid is tpep, or tpless, it should try and map to the the right breakup
  • Add test for checking rid based on tpep and tpless
  • remove rid from links generated by the sdk
  • Dashboard API for chaning user password needs to be tested (userPasswordPut)

@rishabhpoddar rishabhpoddar changed the base branch from 0.17 to 0.18 April 30, 2024 18:34
@rishabhpoddar rishabhpoddar changed the base branch from 0.18 to 0.20 May 24, 2024 05:48
@rishabhpoddar rishabhpoddar marked this pull request as ready for review May 24, 2024 05:48
@rishabhpoddar rishabhpoddar merged commit 533bd14 into 0.20 May 24, 2024
4 of 9 checks passed
@rishabhpoddar rishabhpoddar deleted the remove-combination-recipe/base branch May 24, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant