feat: add dio extension for flexible interseptor setup and update dio and mutex packages #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @daniil-borovoy You can mark me as a reviewer for this whenever you are ready for this PR to be merged |
Sure! |
daniilborovoy
changed the title
daniilborovoy
changed the title
rishabhpoddar
suggested changes
Nov 9, 2023
Comment on lines
+92
to
+98
| import 'package:supertokens_flutter/dio.dart'; | ||
|
|
||
| void setup() { | ||
| Dio dio = Dio(); // Create a Dio instance. | ||
| dio.addSupertokensInterceptor(); | ||
| } | ||
| ``` |
There was a problem hiding this comment.
is this a better way over the existing method? If so, do you think we should recommend this method on our website docs?
There was a problem hiding this comment.
Yes, I was inspired by the Flutter Sentry SDK and they do the same thing in their SDK. So you can use the cascade operator and make something like this
Dio(options) ..addSentry() ..addSupertokensInterceptor()
There was a problem hiding this comment.
Gotcha! thanks. Keeping this comment open cause we will add it to our docs.
Co-authored-by: Rishabh Poddar <[email protected]>
rishabhpoddar
suggested changes
Nov 13, 2023
daniilborovoy
changed the title
rishabhpoddar
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
Related issues