From aaf78f9feadec3ab097f5c748ed9b6eabdc805a3 Mon Sep 17 00:00:00 2001 From: Chakravarthi Medicharla Date: Thu, 28 Sep 2023 11:59:37 +0530 Subject: [PATCH] incorporate suggested changes --- lib/build/thirdparty-shared.js | 3 --- lib/ts/recipe/thirdparty/providers/twitter.tsx | 6 +----- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/lib/build/thirdparty-shared.js b/lib/build/thirdparty-shared.js index 3bc317fe4..28c43117c 100644 --- a/lib/build/thirdparty-shared.js +++ b/lib/build/thirdparty-shared.js @@ -1019,9 +1019,6 @@ var Twitter = /** @class */ (function (_super) { if (normalisedUseLegacyTwitterLogo) { name = "Twitter"; } - if ((config === null || config === void 0 ? void 0 : config.id) !== undefined) { - id = config.id; - } _this = _super.call(this, genericComponentOverrideContext.__assign({ id: id, name: name }, config)) || this; _this.useLegacyTwitterLogo = false; _this.getLogo = function () { diff --git a/lib/ts/recipe/thirdparty/providers/twitter.tsx b/lib/ts/recipe/thirdparty/providers/twitter.tsx index 1c451a560..20470e724 100644 --- a/lib/ts/recipe/thirdparty/providers/twitter.tsx +++ b/lib/ts/recipe/thirdparty/providers/twitter.tsx @@ -39,7 +39,7 @@ export default class Twitter extends Provider { * Constructor. */ constructor(config?: TwitterProviderConfig) { - let id = "twitter"; + const id = "twitter"; let name = "X"; const normalisedUseLegacyTwitterLogo = config?.useLegacyTwitterLogo === true; @@ -48,10 +48,6 @@ export default class Twitter extends Provider { name = "Twitter"; } - if (config?.id !== undefined) { - id = config.id; - } - super({ id, name,