From 4ac34fda1b0300cdd2ea5b7c56860b76196984e9 Mon Sep 17 00:00:00 2001 From: Amit Badala Date: Sun, 26 Nov 2023 12:22:24 +0530 Subject: [PATCH] Event handler props on input component should be non-optional (#768) * Event handler props on input component should be non-optional * version and changelog change --------- Co-authored-by: rishabhpoddar --- CHANGELOG.md | 6 +++++- .../emailpassword/components/library/input.d.ts | 6 +++--- lib/build/version.d.ts | 2 +- .../emailpassword/components/library/input.tsx | 6 +++--- lib/ts/version.ts | 2 +- package-lock.json | 4 ++-- package.json | 2 +- test/with-typescript/src/App.tsx | 16 ++++------------ 8 files changed, 20 insertions(+), 24 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1c84f6e6e..2e2748aad 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html) -## [0.35.7] - 2023-11-16 +## [0.35.8] - 2023-11-26 + +- Fixes `inputComponent` props to make them non optional. This is in the context of customizing the sign up form to add custom react components. + +## [0.35.7] - 2023-11-24 ### Added diff --git a/lib/build/recipe/emailpassword/components/library/input.d.ts b/lib/build/recipe/emailpassword/components/library/input.d.ts index 973042e7c..beb678655 100644 --- a/lib/build/recipe/emailpassword/components/library/input.d.ts +++ b/lib/build/recipe/emailpassword/components/library/input.d.ts @@ -8,9 +8,9 @@ export declare type InputProps = { hasError: boolean; placeholder: string; value: string; - onInputBlur?: (value: string) => void; - onInputFocus?: (value: string) => void; - onChange?: (value: string) => void; + onInputBlur: (value: string) => void; + onInputFocus: (value: string) => void; + onChange: (value: string) => void; }; declare const Input: React.FC; export default Input; diff --git a/lib/build/version.d.ts b/lib/build/version.d.ts index 61197a780..cfe379a1e 100644 --- a/lib/build/version.d.ts +++ b/lib/build/version.d.ts @@ -1 +1 @@ -export declare const package_version = "0.35.7"; +export declare const package_version = "0.35.8"; diff --git a/lib/ts/recipe/emailpassword/components/library/input.tsx b/lib/ts/recipe/emailpassword/components/library/input.tsx index 0f1877e1b..ed0941542 100644 --- a/lib/ts/recipe/emailpassword/components/library/input.tsx +++ b/lib/ts/recipe/emailpassword/components/library/input.tsx @@ -31,9 +31,9 @@ export type InputProps = { hasError: boolean; placeholder: string; value: string; - onInputBlur?: (value: string) => void; - onInputFocus?: (value: string) => void; - onChange?: (value: string) => void; + onInputBlur: (value: string) => void; + onInputFocus: (value: string) => void; + onChange: (value: string) => void; }; const Input: React.FC = ({ diff --git a/lib/ts/version.ts b/lib/ts/version.ts index 8d697de72..a6d28e815 100644 --- a/lib/ts/version.ts +++ b/lib/ts/version.ts @@ -12,4 +12,4 @@ * License for the specific language governing permissions and limitations * under the License. */ -export const package_version = "0.35.7"; +export const package_version = "0.35.8"; diff --git a/package-lock.json b/package-lock.json index f2efb65d3..c16a56d1a 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "supertokens-auth-react", - "version": "0.35.7", + "version": "0.35.8", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "supertokens-auth-react", - "version": "0.35.7", + "version": "0.35.8", "license": "Apache-2.0", "dependencies": { "intl-tel-input": "^17.0.19", diff --git a/package.json b/package.json index eedec85f3..cb820d2cf 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "supertokens-auth-react", - "version": "0.35.7", + "version": "0.35.8", "description": "ReactJS SDK that provides login functionality with SuperTokens.", "main": "./index.js", "engines": { diff --git a/test/with-typescript/src/App.tsx b/test/with-typescript/src/App.tsx index 25ee1151f..167a3a565 100644 --- a/test/with-typescript/src/App.tsx +++ b/test/with-typescript/src/App.tsx @@ -400,9 +400,7 @@ function getEmailPasswordConfigs() { value={inputProps.value} checked={inputProps.value === "true"} onChange={(e) => { - if (inputProps.onChange) { - inputProps.onChange(e.target.checked.toString()); - } + inputProps.onChange(e.target.checked.toString()); }}> I agree to the terms and conditions @@ -421,21 +419,15 @@ function getEmailPasswordConfigs() { inputComponent: (inputProps) => (