Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading state blink behaviour on user list table #23

Open
nkshah2 opened this issue Aug 18, 2022 · 2 comments
Open

Fix loading state blink behaviour on user list table #23

nkshah2 opened this issue Aug 18, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@nkshah2
Copy link
Contributor

nkshah2 commented Aug 18, 2022

Because the API responds really quickly the loading state blinks in and out in less than a second which looks really strange.

We should change the behaviour to show the loading state only if the API doesnt respond in some time (500ms for example)

@nkshah2 nkshah2 added the enhancement New feature or request label Aug 18, 2022
@sulha199
Copy link
Contributor

@nkshah2 we cannot estimate how long the duration of the request. Let say we get a 550ms, then we delay showing the loading until 500ms. It will also blink for 50ms which is not good as well.

If the problem is related with the columns that shift during the loading, then we should define the width for each individual column to minimize shifting.

@nkshah2
Copy link
Contributor Author

nkshah2 commented Aug 22, 2022

We dont need to estimate the duration of the request, we can just decide to show nothing on screen for the initial load and only show the loader after 100ms if the network request has not finished for example

That way the loader wont blink in and out instantly, we can discuss this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants