Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Wallet connection #3448

Closed
paolomolo opened this issue Jan 8, 2025 · 2 comments · Fixed by #3452
Closed

Improve Wallet connection #3448

paolomolo opened this issue Jan 8, 2025 · 2 comments · Fixed by #3452
Assignees

Comments

@paolomolo
Copy link
Collaborator

Wallet side:

  • Add checkbox to wallet login that sets Don't ask for login requests to true, with text: "Remember me?" (default: true)

Image

Image

  • add this switch to the bottom of the popup

  • on clicking disconnect in the dapp we should set Don't ask for login requests to false


Note for BCL side:

  • When the user refresh the browser a full re-connection to the wallet should happen to avoid to popups (new tab)
@onvisions
Copy link
Collaborator

@paolomolo @smaroudasunicorn

I'm suggesting a small UI change: to have a checkbox instead of a switch for the connect modal (see the design below). Reason for that is that the action "Remember me" will be set in this modal only once and then the user will have no access to the setting to switch it on/off until the permission itself is not changed manually in the wallet or in the dApp (by clicking disconnect).

On the other hand in the wallet Settings/Permissions we will continue to use the switches because these settings are accessible to the user at any moment to change (on/off) a specific permission.

I don't have strong opinion on this but I feel it somehow more intuitive with the checkbox as far as the dapp connection modal is concerned.

DESIGN:

  1. Remember me = true (default), Don't ask for login requests = true (default).

Image
Image

  1. Remember me = false, Don't ask for login requests = false.

Image
Image

FIGMA REFERENCE: https://www.figma.com/design/3oGLWzSH0oJljo4RETZtur/Superhero-Wallet-UI-(%E2%9C%94%EF%B8%8FUpdated)?node-id=38349-287124&t=JiR3r6Y8ZcFAc0of-0

@smaroudasunicorn
Copy link
Collaborator

I am ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants