Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to use Layout.ContentSplitter component? #666

Open
tomaskikutis opened this issue Aug 25, 2022 · 5 comments
Open

How to use Layout.ContentSplitter component? #666

tomaskikutis opened this issue Aug 25, 2022 · 5 comments
Assignees
Labels

Comments

@tomaskikutis
Copy link
Member

I currently add it the following way:

<Layout.LayoutContainer>...</Layout.LayoutContainer>

<Layout.ContentSplitter visible={true} />

<Layout.AuthoringContainer open={this.state.rundownIdInEditMode != null}>...</Layout.AuthoringContainer>

The are 2 problems:

  • Unless there's an element forcing height, the splitter collapses and content is not visible: video
  • Resizing sections doesn't work
@fritzSF
Copy link
Collaborator

fritzSF commented Aug 30, 2022

The ContentSplitter is basicaly only a divider between the list/content view and the editor. The splitter functionality isn't done on the framework side. We should have a discussion about that, if and how we should implement it. As for the other issues let us discuss it in a live sesion, I can't tell what it is based on the layout code I can see in the video.

@tomaskikutis
Copy link
Member Author

The splitter functionality isn't done on the framework side. We should have a discussion about that, if and how we should implement it.

I saw there are 3rd party splitter libraries that do have resizing implemented. Maybe you could take one of them, modify the design if you want to, and make it available as an ui-framework component?

@fritzSF
Copy link
Collaborator

fritzSF commented Aug 30, 2022

We started looking at some available options, this one seems promising for our purpose: https://www.npmjs.com/package/@geoffcox/react-splitter
We'll probably add it for testing.

@pavlovicnemanja pavlovicnemanja self-assigned this Sep 15, 2022
@tomaskikutis
Copy link
Member Author

content collapsing is fixed, resizing won't be implemented for rundowns MVP

@pavlovicnemanja
Copy link
Contributor

Lets keep it for now, because we won't to implement splitter in this version of ui framework

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants