From 10b6b862c550260b1248fcd6eeec730a29a300f9 Mon Sep 17 00:00:00 2001 From: Konstantin Markov Date: Mon, 25 Nov 2024 11:23:09 +0200 Subject: [PATCH] Pin chrome version (#4690) --- .github/workflows/tests.yml | 33 +++++++++++---------------------- e2e/client/protractor.conf.js | 2 +- 2 files changed, 12 insertions(+), 23 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index a1651d824f..c668ad2c7e 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -1,79 +1,68 @@ name: "CI" - on: [push, pull_request] - jobs: - test: - runs-on: ubuntu-latest - steps: - uses: actions/checkout@v4 - - uses: actions/setup-node@v4 with: node-version: '14.x' - # avoid file watch limit error - run: echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p - - run: npm ci - run: npm run test || npm run test || npm run test env: TZ: "Europe/Prague" - e2e: runs-on: ubuntu-latest - strategy: fail-fast: false matrix: suite: [a, b] - steps: - uses: actions/checkout@v4 - - uses: actions/setup-node@v4 with: node-version: '14.x' - - - name: Start e2e server run: | docker compose pull docker compose build docker compose up -d working-directory: e2e/server - - name: Build client run: npm install && npm run build && npm run specs--compile && npm run start-client-server working-directory: e2e/client - # playwright start - - name: Install Playwright Browsers run: npx playwright install --with-deps working-directory: e2e/client - - name: Run Playwright tests run: npx playwright test working-directory: e2e/client - - uses: actions/upload-artifact@v4 if: ${{ failure() }} with: name: playwright-report-${{ matrix.suite }} path: e2e/client/test-results - # playwright end # protractor start + - name: Setup Chrome + uses: browser-actions/setup-chrome@v1 + id: setup-chrome + with: + chrome-version: 127.0.6533.99 + install-dependencies: true + install-chromedriver: true - - name: Protractor - run: npx protractor-flake --parser standard --max-attempts=3 -- protractor.conf.js --suite=${{ matrix.suite }} + - name: Run Protractor + run: npx protractor-flake --parser standard --max-attempts=3 -- protractor.conf.js --suite=${{ matrix.suite }} env: + CHROME_BIN: ${{ steps.setup-chrome.outputs.chrome-path }} + CHROMEWEBDRIVER: ${{ steps.setup-chrome.outputs.chromedriver-path }} TRAVIS: ci SCREENSHOTS_DIR: /tmp working-directory: e2e/client diff --git a/e2e/client/protractor.conf.js b/e2e/client/protractor.conf.js index a5950fed3e..d614689312 100644 --- a/e2e/client/protractor.conf.js +++ b/e2e/client/protractor.conf.js @@ -53,7 +53,7 @@ var config = { directConnect: true, - chromeDriver: process.env.CHROMEWEBDRIVER ? (process.env.CHROMEWEBDRIVER + '/chromedriver') : null, + chromeDriver: process.env.CHROMEWEBDRIVER ? process.env.CHROMEWEBDRIVER : null, onPrepare: function() { execSync(