Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: do NOT trap exits in tests #501

Merged
merged 1 commit into from
Nov 27, 2024
+0 −59
Merged

test: do NOT trap exits in tests #501

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 0 additions & 59 deletions test/integration/proxy_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ defmodule Supavisor.Integration.ProxyTest do
end

test "the wrong password" do
Process.flag(:trap_exit, true)
db_conf = Application.get_env(:supavisor, Repo)

url =
Expand Down Expand Up @@ -216,7 +215,6 @@ defmodule Supavisor.Integration.ProxyTest do
end

test "limit client connections" do
Process.flag(:trap_exit, true)
db_conf = Application.get_env(:supavisor, Repo)

connection_opts = [
Expand All @@ -240,7 +238,6 @@ defmodule Supavisor.Integration.ProxyTest do
end

test "change role password", %{origin: origin} do
Process.flag(:trap_exit, true)
db_conf = Application.get_env(:supavisor, Repo)

conn = fn pass ->
Expand Down Expand Up @@ -270,7 +267,6 @@ defmodule Supavisor.Integration.ProxyTest do
end

test "invalid characters in user or db_name" do
Process.flag(:trap_exit, true)
db_conf = Application.get_env(:supavisor, Repo)

url =
Expand All @@ -288,62 +284,7 @@ defmodule Supavisor.Integration.ProxyTest do
}} = parse_uri(url) |> single_connection()
end

# test "max_pools limit" do
# Process.flag(:trap_exit, true)
# db_conf = Application.get_env(:supavisor, Repo)
# port = Application.get_env(:supavisor, :proxy_port_transaction)

# tenant = "max_pool_tenant"

# {:ok, pid1} =
# Keyword.merge(db_conf,
# username: "postgres.#{tenant}",
# port: port
# )
# |> single_connection()

# assert Supavisor.count_pools(tenant) == 1

# {:ok, pid2} =
# Keyword.merge(db_conf,
# username: "session.#{tenant}",
# port: port
# )
# |> single_connection()

# assert Supavisor.count_pools(tenant) == 2

# {:ok, pid3} =
# Keyword.merge(db_conf,
# username: "transaction.#{tenant}",
# port: port
# )
# |> single_connection()

# assert Supavisor.count_pools(tenant) == 3

# connection_opts =
# Keyword.merge(db_conf,
# username: "max_clients.#{tenant}",
# port: port
# )

# assert {:error,
# %Postgrex.Error{
# postgres: %{
# code: :internal_error,
# message: "Max pools count reached",
# unknown: "FATAL",
# severity: "FATAL",
# pg_code: "XX000"
# }
# }} = single_connection(connection_opts)

# for pid <- [pid1, pid2, pid3], do: :gen_statem.stop(pid)
# end

test "active_count doesn't block" do
Process.flag(:trap_exit, true)
db_conf = Application.get_env(:supavisor, Repo)
port = Application.get_env(:supavisor, :proxy_port_session)

Expand Down
Loading