Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database build script #27

Open
n1c0z opened this issue Aug 10, 2018 · 0 comments
Open

Database build script #27

n1c0z opened this issue Aug 10, 2018 · 0 comments

Comments

@n1c0z
Copy link

n1c0z commented Aug 10, 2018

Nicely structured SQL script. 👍

Only a couple of suggestions that you may find useful:

  • Like that you have kept most of your VARCHARs for email and names to 80. Personally, I am happy to keep it to 255 which I think is the default value.
  • TEXT I believe is anything above 4000 characters (I think that's about 2-3 pages in Word). Feel free to use VARCHAR instead with a smaller number if storage would be an issue.
  • I would probably move the on_loan field to loans as this is a dynamic field while the items table is quite static. Normally historical data are tend to be kept in a separate table from non-frequently updated tables, i.e. users / user-logins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants