Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fetch API #145

Closed
enricobottazzi opened this issue Aug 29, 2023 · 1 comment · Fixed by #152
Closed

Remove fetch API #145

enricobottazzi opened this issue Aug 29, 2023 · 1 comment · Fixed by #152
Assignees

Comments

@enricobottazzi
Copy link
Member

The latest update of summa, after #141 is merged, will support any cryptocurrencies with no difference or preference.

Therefore, the fetch API should be able to fetch balances from any blockchain at any block. The current backend implementation only partially supports it => now only able to fetch ETH (at any block) and ERC20 (only at the most recent block).

I believe that removing the feature as a whole is better than having a partially functioning feature.

@enricobottazzi enricobottazzi added this to the Blog Post Release milestone Aug 29, 2023
@enricobottazzi enricobottazzi moved this to Backlog in ∑ Summa Aug 31, 2023
@enricobottazzi enricobottazzi removed this from the Blog Post Release milestone Aug 31, 2023
@sifnoc
Copy link
Member

sifnoc commented Sep 11, 2023

This issue can be resolved following #152
The related commit can be found 9a93558

@enricobottazzi enricobottazzi moved this from Backlog to Under Review in ∑ Summa Sep 12, 2023
@enricobottazzi enricobottazzi linked a pull request Sep 12, 2023 that will close this issue
@github-project-automation github-project-automation bot moved this from Under Review to Merged in ∑ Summa Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging a pull request may close this issue.

2 participants