Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-poetry dependencies #133

Open
edsu opened this issue Aug 2, 2022 · 4 comments
Open

Remove non-poetry dependencies #133

edsu opened this issue Aug 2, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@edsu
Copy link
Contributor

edsu commented Aug 2, 2022

To prevent confusion we should remove the previously installed pywb and cdxj-indexer (those that were not installed with Poetry) that are in /opt/apt/was/.local. This can be done by sshing into each environment and doing a:

pip uninstall pywb cdxj-indexer

The Docker instructions also need to be modified to use poetry run with cdxj-indexer. Now that nginx is no longer being used here we can move the contents of the pywb directory in this repo up one level into the base directory. This will mean you won't need to cd pywb prior to running commands with poetry run. However this will likely require changing the systemd process to not use the subdirectory when referencing the uwsgi.conf.

@edsu edsu added the bug Something isn't working label Aug 2, 2022
@lwrubel
Copy link
Contributor

lwrubel commented Aug 2, 2022

I think we may also need to add poetry run to the docker compose example cdxj-indexer commands in the README.

@edsu
Copy link
Contributor Author

edsu commented Aug 2, 2022

Yes, now that nginx is gone I think it may make sense to move the contents of the pywb directory in git up into the main folder? Then a cd pywb won't be needed before the poetry run? This may effect some other things though, such as the systemd process.

Fortunately it looks like the systemd command IS using the Poetry environment. So other than making the Docker dev environment work this is mainly an issue for was_robot_suite I think?

@edsu
Copy link
Contributor Author

edsu commented Aug 2, 2022

My bad, it looks like poetry IS being used in was_robot_suite after all. I think it would be good to remove the pip installed version in all environments to prevent future confusion.

@edsu
Copy link
Contributor Author

edsu commented Aug 2, 2022

I've updated the title and description of this ticket to be less alarmist :-)

@edsu edsu changed the title Poetry environment not being used Remove non-poetry dependencies Aug 2, 2022
edsu added a commit that referenced this issue Aug 7, 2022
In order to reindex using the Docker development environmemt the `poetry
run` command will need to be used.

Refs #133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants