Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

throw more specific exceptions; caller handles as desired #44

Open
ndushay opened this issue Nov 5, 2019 · 1 comment
Open

throw more specific exceptions; caller handles as desired #44

ndushay opened this issue Nov 5, 2019 · 1 comment

Comments

@ndushay
Copy link
Contributor

ndushay commented Nov 5, 2019 •
edited
Loading

This is in contradiction to merged PR #41

Possibly diff flavors of exceptions

  • invalid year (e.g. 2050)
  • unparseable year
  • last year earlier than first year

etc.
@ndushay ndushay changed the title consider throwing more exceptions and having caller turn into nil value consider throwing more exceptions and having caller create nil value if desired Nov 5, 2019
@ndushay ndushay changed the title consider throwing more exceptions and having caller create nil value if desired throw more specific exception; caller handles as desired Nov 5, 2019
@ndushay ndushay changed the title throw more specific exception; caller handles as desired throw more specific exceptions; caller handles as desired Nov 5, 2019
@mjgiarlo
Copy link
Member

mjgiarlo commented Nov 8, 2019 •
edited
Loading

@aaron-collier @ndushay Giving up on this one. I suspect it'll be easier to disentangle validation and parsing after another round or two of refactoring, so leaving the issue open. I moved the issue to the backlog.

@mjgiarlo mjgiarlo removed their assignment Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ndushay @mjgiarlo