Creates backstage selection dag #1463
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dict and adds test.
jermnelson
approved these changes
Nov 27, 2024
| logger.info( | ||
| f"Removed MARC fields and serialized records for '{kind}' files: {marc_file_list[kind]}" | ||
| ) | ||
| for kind, file_list in marc_file_list.items(): |
There was a problem hiding this comment.
I like this approach of using the key in the marc_file_list over hard-coding the kind values in a list; more extensible this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1439
I tried running locally but then I remembered I can't connect to postgres.