use Dor::TextExtraction::DorEventLogger consistently across the codebase for sending events #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartin-sul
force-pushed
the
fixup-dor-event-logging
branch
2 times, most recently
from
4e7ed13
to
a3855f6
Compare
…ase for sending events
…the level of abstraction used in the class this follows a refactoring to consistently use Dor::TextExtraction::DorEventLogger (instead of Dor::Services::Client) for event creation
jmartin-sul
force-pushed
the
fixup-dor-event-logging
branch
from
a3855f6
to
1f2dabc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was this change made? 🤔
fixes #1412
How was this change tested? 🤨
⚡ ⚠ If this change has cross service impact, including writes to shared file systems, run integration tests and/or test in [stage|qa] environment, in addition to specs. ⚡