Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(common):[components] add WIconButton #304

Closed
wants to merge 1 commit into from
Closed

feat(common):[components] add WIconButton #304

wants to merge 1 commit into from

Conversation

V1C70RYG0D
Copy link
Contributor

part of #272

@meganindya
Copy link
Member

We should rather use SImage component instead. Updated the description. Please make the change, should be trivial.

niloysikdar
niloysikdar requested changes Jan 23, 2023
View reviewed changes
Copy link
Member

@niloysikdar niloysikdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you made some typos in the file name for the story.
You made it insex.stories.tsx, which should be ideally index.stories.tsx

@V1C70RYG0D V1C70RYG0D closed this Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niloysikdar niloysikdar niloysikdar requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@V1C70RYG0D @meganindya @niloysikdar