From 4a525e9fc4b6e4a53766ec8e27166af515dab67f Mon Sep 17 00:00:00 2001 From: John Guibas Date: Mon, 3 Jun 2024 00:34:35 -0700 Subject: [PATCH] chore: increase byte lookup channes (#876) --- core/src/bytes/mod.rs | 2 +- core/src/stark/chip.rs | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/core/src/bytes/mod.rs b/core/src/bytes/mod.rs index f6d5bc482c..2cf8c8fb1c 100644 --- a/core/src/bytes/mod.rs +++ b/core/src/bytes/mod.rs @@ -24,7 +24,7 @@ use crate::bytes::trace::NUM_ROWS; pub const NUM_BYTE_OPS: usize = 9; /// The number of different byte lookup channels. -pub const NUM_BYTE_LOOKUP_CHANNELS: u32 = 4; +pub const NUM_BYTE_LOOKUP_CHANNELS: u32 = 16; /// A chip for computing byte operations. /// diff --git a/core/src/stark/chip.rs b/core/src/stark/chip.rs index c3e8abdc09..7248e73a46 100644 --- a/core/src/stark/chip.rs +++ b/core/src/stark/chip.rs @@ -65,6 +65,20 @@ where air.eval(&mut builder); let (sends, receives) = builder.interactions(); + let nb_byte_sends = sends + .iter() + .filter(|s| s.kind == InteractionKind::Byte) + .count(); + let nb_byte_receives = receives + .iter() + .filter(|r| r.kind == InteractionKind::Byte) + .count(); + tracing::debug!( + "chip {} has {} byte interactions", + air.name(), + nb_byte_sends + nb_byte_receives + ); + let mut max_constraint_degree = get_max_constraint_degree(&air, air.preprocessed_width(), PROOF_MAX_NUM_PVS);