Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: transform union_distinct op into set operation that supports all enumerations #27

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dshaaban01
Copy link
Contributor

@dshaaban01 dshaaban01 commented Nov 29, 2024

  • Changed UnionDistinctOp into SetOp that contains enum's for all the set relations. Adjusted valid and invalid test cases to include all the enumerations.
  • Adjusted return type inference function to handle all enum's.
  • Adjusted export function to handle other enum's + adjusted test case to handle all enumerations.
  • Adjusted import function to handle other enum's + adjusted test case to handle all enumerations.

Note: This implementation only works for two inputs. TODO: extend to support repeatable inputs.

@dshaaban01 dshaaban01 changed the title feat : transform union_distinct op into set operation that supports all enumerations feat: transform union_distinct op into set operation that supports all enumerations Nov 29, 2024
@dshaaban01
Copy link
Contributor Author

@ingomueller-net

Enums ready!

@CLAassistant
Copy link

CLAassistant commented Nov 29, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants