Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submariner (including Globalnet) should be enhanced to support nftables. #1775

Open
sridhargaddam opened this issue Apr 7, 2022 · 10 comments
Assignees
Labels
enhancement New feature or request size:medium This can be implemented in a single sprint

Comments

@sridhargaddam
Copy link
Member

Some of the platforms are moving away from iptables backend to nftables backend. One such example is RHEL9.
As part of this transition, the tools like iptables, ipsets etc are deprecated - https://access.redhat.com/solutions/6739041

Submariner pods like Globalnet, route-agent which program iptable rules on the nodes should now query if the underlying host uses iptables or nftables and ensure that its programming the necessary rules that are supported by the underlying host.

@sridhargaddam sridhargaddam added the enhancement New feature or request label Apr 7, 2022
@sridhargaddam
Copy link
Member Author

CC @nyechiel @skitt @yboaron

@skitt
Copy link
Member

skitt commented Apr 7, 2022

We already handle this partially – the tools we install in the container images use either the legacy or nft iptables backend.

I agree we do need to take care of this properly; anywhere we manipulate iptables and/or ipsets needs to be able to use nftables directly if appropriate.

I don’t think this is urgent for 0.13, it can wait until the release after that.

@sridhargaddam
Copy link
Member Author

Currently, in an OCP 0.10 setup, we have seen that underlying host is using NFTables and the iptable/ipset rules programmed by Submariner Globalnet/Route-agent seem to get automatically translated without any issues except for the tcpd-mss-clamp rules for which I reported a separate issue - #1774

As long as the iptables/ipsets binary is present and automatic translation is working fine, we are good. But before these binaries are removed from the host/container, we have to enhance SM to program rules using nft. Anyways, I too believe that this is not urgent for 0.13 and can wait.

@stale
Copy link

stale bot commented Aug 11, 2022

This issue has been automatically marked as stale because it has not had activity for 60 days. It will be closed if no further activity occurs. Please make a comment if this issue/pr is still valid. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 11, 2022
@skitt skitt removed the wontfix This will not be worked on label Aug 16, 2022
@sridhargaddam sridhargaddam added size:medium This can be implemented in a single sprint priority:low next-version-candidate labels Nov 15, 2022
@stale
Copy link

stale bot commented Mar 18, 2023

This issue has been automatically marked as stale because it has not had activity for 60 days. It will be closed if no further activity occurs. Please make a comment if this issue/pr is still valid. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 18, 2023
@dfarrell07
Copy link
Member

This would greatly simplify our shipped containers/binaries/code, but it will only really help a lot once we don't need to support hosts without nftables.

@dfarrell07 dfarrell07 removed the wontfix This will not be worked on label Mar 28, 2023
@stale
Copy link

stale bot commented Sep 17, 2023

This issue has been automatically marked as stale because it has not had activity for 60 days. It will be closed if no further activity occurs. Please make a comment if this issue/pr is still valid. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 17, 2023
@nyechiel nyechiel added size:large This needs more than one sprint to be implemented size:medium This can be implemented in a single sprint next-version-candidate and removed wontfix This will not be worked on size:medium This can be implemented in a single sprint priority:low size:large This needs more than one sprint to be implemented labels Sep 17, 2023
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further
activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 16, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 23, 2024
@skitt skitt reopened this Jan 23, 2024
@skitt skitt removed the stale label Jan 23, 2024
Copy link
Contributor

github-actions bot commented Jun 5, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further
activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 5, 2024
@yboaron yboaron self-assigned this Jun 5, 2024
@github-actions github-actions bot removed the stale label Jun 6, 2024
@maayanf24 maayanf24 added this to Backlog Jul 2, 2024
@maayanf24 maayanf24 moved this to Backlog in Backlog Jul 2, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further
activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 4, 2024
@tpantelis tpantelis removed the stale label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:medium This can be implemented in a single sprint
Projects
Status: Backlog
Development

No branches or pull requests

6 participants