-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default scope for class names? #445
Comments
My intent is to standardize on In general, my recommendation will be to have color schemes highlight the following selectors:
There is one instance of To keep more strict adherence with old syntaxes and color schemes we could put everything from |
Out of curiosity, is there any non- Edit: there's |
@wbond: Thanks for the information. I prefer From the list @FichteFoll provided it looks like in the color schemes he checked |
This has been resolved for all of the syntaxes we've worked on rewriting recently. Work will continue on others and I will document |
The discussion here wesbos/cobalt2#104 led me to this wesbos/cobalt2#103 regarding ES6 class highlighting in JavaScript.
Examining the scope name used by a handful of the default syntaxes for class names it looks like they are split between
entity.name.class.xxx
(e.g. C++ and PHP) andentity.name.type.class.xxx
(e.g. JavaScript, Java, Python). Is there a reason for this difference? If not, perhaps it would be a good idea to standardize on one scope name or the other?The text was updated successfully, but these errors were encountered: