[php] Build 3114 syntax highlighting misses keywords

[danielbachhuber]

Here are some keywords that are missing for me:

Build 3114:

$bits = explode( '/', $assoc_args['name'] );
if ( 2 !== count( $bits ) || empty( $bits[0] ) || empty( $bits[1] ) ) {
    WP_CLI::error( "'{$assoc_args['name']}' is an invalid package name. Package scaffold expects '<author>/<package>'." );
}

<?php

namespace WP_CLI;

use WP_CLI;
use WP_CLI\Process;
use WP_CLI\Utils;

Build 3013:

Originally #389 (comment)

[wbond]

The scopes changes since 3103 since the PHP syntax has been heavily refactored to support new syntax and better handle various constructs.

I've confirmed that error in WP_CLI::error() is getting the correct scopes. The most specific part is:

meta.function-call.static variable.function

In the use statements example, the identifiers are getting the correct scopes also. When use is encountered, it is unknown if the path ends in a namespace, or a class name. Thus, we don't highlight the final identifier with any specific scope. However, namespace names preceding the final identifier do have the scope support.other.namespace.

I'd be open to ideas on how to handle the ambiguity of scoping namespace/class names in a use statement.

[wesbos]

Hey - does this mean that my theme should be updated? It's not an error on the highlighter side, but the theme should handle the new scope?

[wbond]

@wesbos Yes, some of the scope names have changed as we are making things more consistent. If you want to retain the same colors as before for the tokens in the screen shots, I believe your color scheme will need a few tweaks. I believe the advice from @FichteFoll at wesbos/cobalt2#104 should help in getting the colors back to where they were before.

[wbond]

I don't believe there is anything to be done here, closing.