Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust] Ligatures mis-grouped #2147

Closed
Shadlock0133 opened this issue Oct 25, 2019 · 5 comments
Closed

[Rust] Ligatures mis-grouped #2147

Shadlock0133 opened this issue Oct 25, 2019 · 5 comments

Comments

@Shadlock0133
Copy link

Shadlock0133 commented Oct 25, 2019

  • Sublime Version: 3.2.2
  • OS Version: Windows 8.1
bitmask >>= 1;

I'm using a Fira Code font.

In Rust file:
image

For comparison, same line in C file:
image

@urschrei
Copy link

Does this problem also occur when using Rust-Enhanced? (https://github.com/rust-lang/rust-enhanced). If it does, you should open an issue there, as that's where the Rust syntax development happens.

@wbond
Copy link
Member

wbond commented Nov 15, 2019

@urschrei Unfortunately, no, Rust Enhanced generally does not upstream on contribute bug reports or fixes here, even after I have asked if they would work with us. They don’t like waiting for new builds to get fixes out, which is understandable, but also prefer not to follow the scope naming guidelines, so the syntaxes have diverged.

@Shadlock0133
Copy link
Author

I tested it and the syntax file from Rust-Enhanced fixes the issue.

TheClams pushed a commit to TheClams/Packages that referenced this issue Nov 16, 2019
Simply swap comparison and assignement operator to be sure
 assignment get tested first.
Add relevant test.

Fixes issue sublimehq#2147
TheClams pushed a commit to TheClams/Packages that referenced this issue Nov 16, 2019
Simply swap comparison and assignement operator to be sure
 assignment get tested first.
Add relevant test.

Fixes issue sublimehq#2147
wbond pushed a commit that referenced this issue Nov 21, 2019
Simply swap comparison and assignement operator to be sure
 assignment get tested first.
Add relevant test.

Fixes issue #2147
@jrappen
Copy link
Contributor

jrappen commented Dec 2, 2019

@wbond Fixed by @TheClams in #2208.

@deathaxe deathaxe closed this as completed Jan 8, 2022
@deathaxe
Copy link
Collaborator

deathaxe commented Jan 8, 2022

Luckily #2305 doesn't break the fix by #2208.

mitranim pushed a commit to mitranim/Packages that referenced this issue Mar 25, 2022
Simply swap comparison and assignement operator to be sure
 assignment get tested first.
Add relevant test.

Fixes issue sublimehq#2147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants