Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stylelintrc.json should ignore namespaced rules #438

Closed
Mouvedia opened this issue Nov 12, 2024 · 4 comments · Fixed by #439
Closed

stylelintrc.json should ignore namespaced rules #438

Mouvedia opened this issue Nov 12, 2024 · 4 comments · Fixed by #439
Labels
status: wip is being worked on by someone

Comments

@Mouvedia
Copy link
Member

Mouvedia commented Nov 12, 2024 •
edited
Loading

What is the problem you're trying to solve?

config tab

{
  "plugins": "@stylistic/stylelint-plugin",
  "rules": {
    "@stylistic/string-quotes": "single"
  }
}

What solution would you like to see?

		"rules": {
			"properties": {
				"alpha-value-notation": {
				[…]
			},
			"patternProperties": {
              // TBD
			},
		}

ref https://json-schema.org/understanding-json-schema/reference/object#patternProperties
@ota-meshi
Copy link
Member

Hmm... Is this an issue with the JSON schema registered in the Json Schema Store?
https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/stylelintrc.json

@Mouvedia
Copy link
Member Author

Mouvedia commented Nov 13, 2024 •
edited
Loading

Is this an issue with the JSON schema registered in the Json Schema Store?

No it's not.
I just need to update https://github.com/stylelint/stylelint-demo/blob/main/src/schema/stylelintrc.json
I currently don't have time to check the pattern allowed for namespaces.

Do we inherit npm scope restrictions?
i.e.

  • must be less than or equal to 214 characters
  • can begin with a dot or an underscore
  • can't contain any non-URL-safe characters
  • can't contain uppercase letters

@ota-meshi
Copy link
Member

Oh, I didn't know I had that inside the project. Thank you for letting me know that 😅

@Mouvedia Mouvedia mentioned this issue Nov 18, 2024
Merged
@Mouvedia
Copy link
Member Author

Oh, I didn't know I had that inside the project.

It was a joint effort between @ybiquitous and me.
see #425

@ota-meshi can you add the status: wip label?

@ota-meshi ota-meshi added the status: wip is being worked on by someone label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: wip is being worked on by someone
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for namespaced rules Mouvedia/stylelint-demo
2 participants
@Mouvedia @ota-meshi