Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chown mountpoint at installation, not at login #14

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

juls
Copy link

@juls juls commented Oct 30, 2023

fixes #13

@juls
Copy link
Author

juls commented Nov 18, 2023

Hi @stuartleeks, could you give me some feedback on this PR?

@stuartleeks
Copy link
Owner

Sorry for the delay.

My recollection is that my initial code used this approach, but that it didn't work. IIRC, it was because the install.sh ran during the container build step, but the mount only existed when the container was started and caused an issue

@juls
Copy link
Author

juls commented Dec 22, 2023

You're right, but by creating the mountpoint during build this should be no issue.

@juls
Copy link
Author

juls commented Jan 8, 2024

Thanks for approving the PR, could you please also merge it into main?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shell-history not working with Python virtual environments on Debian Bookworm
3 participants