refactor uncompressed decode #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the enumerations into a shared header file. The sampling type enumeration and interleave type enumeration are renamed to be sampling mode and enumeration mode to match the changes in the FDIS. Documentation is added (although its not public API). The cmpd and uncC box definitions are split off from the codec, to keep file sizes reasonable.
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty large refactoring of the uncompressed codec.
There are two commits. The first splits the uncompressed boxes out into a separate file. That part is basically mechanical.
The second reworks how the uncompressed decode logic works. Previously we tried to pull the right bits into the image. This implementation is closer to the source - we step through the data and push into the image planes. There are multiple decoder implementations, and a factory method to choose which decoder to use. The choices at this point are oriented around interleave, but other options are possible.
There are no changes to the encode side.
There are now many more tests. We now support YCbCr 4:2:2 and 4:2:0 subsampling, and correctly handle component interleave. We also handle component alignment (for at least some cases).
Resolves #904
What is not yet supported:
uncCshort-cut formatEven with all of that, this is a better basis than what we currently have.