Sanitise jpgc box size before memory allocation #1019
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the work for #922 may have removed some existing security checks around memory allocation.EDIT: The
jpgC
logic was introduced in commit 3e82d51 (and #922 moved it).This PR adds sanity checking for
jpgC
box sizes and a 32 byte test file discovered via fuzz testing that will attempt to allocate ~9 exabytes and therefore segfault when parsed using v1.17.x. I've not checked other box types, but it's possible this sanity check may need to be applied in a more general manner to otherparse
functions.