nclx: use default values that match sRGB #1015
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since commit 062b528, libheif saves images with the default NCLX profile
6,6,6
(Rec. 601 aka NTSC) which is pretty far from sRGB and leads to incorrect colors in most viewers. Additionally, thecolr
HEIF box wasn't updated to reflect this.Commit 673fb03 resolves the latter issue by guaranteeing the update of
target_nclx_profile
following the color conversion, thereby ensuring the propagation of any defaults specified inColorConversionPipeline::convert_image()
.Commit 3bc7572 resolves the former issue by ensuring NCLX profiles defaults to
1,13,1
(Rec. 709 with IEC 61966-2-1 transfer function).Context: libvips/libvips#3731
Thanks to @DarthSim for discovering this.