fuzzer: The box_size_without_header must be positive #1012
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought the problem was already fixed with 316291a. |
|
Yes, you're correct. This issue has already been resolved. I'll close the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fuzzer is throwing the following error:
/home/runner/work/libheif/libheif/libheif/box.cc:669:27: runtime error: implicit conversion from type 'int64_t' (aka 'long') of value -8 (64-bit, signed) to type 'size_t' (aka 'unsigned long') changed the value to 18446744073709551608 (64-bit, unsigned)
The BitstreamRange constructor expects a size_t, but an int64_t is being passed in (box.cc line 669). This is a problem when the value is negative.