Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1004

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Update README.md #1004

merged 2 commits into from
Oct 20, 2023

Conversation

arjendekorte
Copy link
Contributor

Using cmake-presets version 3 requires CMake >= 3.21

Using cmake-presets version 3 requires CMake >= 3.21
@farindk
Copy link
Contributor

farindk commented Oct 20, 2023

Thanks. Could we change the text slightly to "--preset argument needs CMake >= 3.21" ?
Otherwise it sounds to me as it cannot be built without 3.21 at all.

@arjendekorte
Copy link
Contributor Author

Agreed. It took me a while to figure out what the problem was, since the CMake error isn't the most helpful to find what is wrong, therefor it might be useful to mention this specifically.

@farindk farindk merged commit 49bd673 into strukturag:master Oct 20, 2023
30 checks passed
@farindk
Copy link
Contributor

farindk commented Oct 20, 2023

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants