From 9d479aba73b630bf44ff803287a914d0a789a3fc Mon Sep 17 00:00:00 2001
From: David Cohen <davidc@jfrog.com>
Date: Tue, 2 Jan 2024 11:20:31 +0200
Subject: [PATCH] Cleaner presets for CMake

---
 CMakePresets.json | 44 +++++++++++++++++++++++++++++++++++++++-----
 README.md         |  3 +++
 2 files changed, 42 insertions(+), 5 deletions(-)

diff --git a/CMakePresets.json b/CMakePresets.json
index dbbcde1db7..0e63e6dbf7 100644
--- a/CMakePresets.json
+++ b/CMakePresets.json
@@ -8,8 +8,42 @@
   "configurePresets": [
     {
       "name": "default",
-      "displayName": "Default Config",
+      "displayName": "Default Config from CMakeLists.txt",
       "description": "Default building parameters",
+      "cacheVariables": {
+        "WITH_AOM_DECODER" : "ON",
+        "WITH_AOM_DECODER_PLUGIN" : "OFF",
+        "WITH_AOM_ENCODER" : "ON",
+        "WITH_AOM_ENCODER_PLUGIN" : "OFF",
+        "WITH_DAV1D" : "OFF",
+        "WITH_DAV1D_PLUGIN" : "ON",
+        "WITH_LIBDE265" : "ON",
+        "WITH_LIBDE265_PLUGIN" : "OFF",
+        "WITH_RAV1E" : "OFF",
+        "WITH_RAV1E_PLUGIN" : "ON",
+        "WITH_SvtEnc" : "OFF",
+        "WITH_SvtEnc_PLUGIN" : "ON",
+        "WITH_X265" : "ON",
+        "WITH_X265_PLUGIN" : "OFF",
+        "WITH_JPEG_DECODER" : "OFF",
+        "WITH_JPEG_DECODER_PLUGIN" : "OFF",
+        "WITH_JPEG_ENCODER" : "OFF",
+        "WITH_JPEG_ENCODER_PLUGIN" : "OFF",
+        "WITH_UNCOMPRESSED_CODEC" : "OFF",
+	"WITH_KVAZAAR" : "OFF",
+	"WITH_KVAZAAR_PLUGIN" : "OFF",
+	"WITH_OpenJPEG_DECODER" : "OFF",
+	"WITH_OpenJPEG_DECODER_PLUGIN" : "ON",
+	"WITH_OpenJPEG_ENCODER" : "OFF",
+	"WITH_OpenJPEG_ENCODER_PLUGIN" : "ON",
+	"WITH_FFMPEG_DECODER" : "OFF",
+	"WITH_FFMPEG_DECODER_PLUGIN" : "OFF"
+      }
+    },
+    {
+      "name": "base",
+      "displayName": "Base Config",
+      "description": "Default base building parameters",
       "cacheVariables": {
         "WITH_AOM_DECODER" : "ON",
         "WITH_AOM_DECODER_PLUGIN" : "ON",
@@ -42,7 +76,7 @@
     },
     {
       "name": "develop",
-      "inherits": "default",
+      "inherits": "base",
       "displayName": "development",
       "description": "Enable all experimental features. Do not use plugins, compile everything built-in.",
       "cacheVariables": {
@@ -73,7 +107,7 @@
     },
     {
       "name": "release",
-      "inherits": "default",
+      "inherits": "base",
       "displayName": "Standard release build",
       "description": "Recommended parameters for a release build.",
       "cacheVariables": {
@@ -112,7 +146,7 @@
     },
     {
       "name": "testing",
-      "inherits": "default",
+      "inherits": "base",
       "displayName": "Tests",
       "description": "For running the tests",
       "cacheVariables": {
@@ -124,7 +158,7 @@
     },
     {
       "name": "fuzzing",
-      "inherits": "default",
+      "inherits": "base",
       "displayName": "Fuzzing",
       "description": "For running the fuzzers",
       "cacheVariables": {
diff --git a/README.md b/README.md
index faf4d9f387..dcf7b3b25b 100644
--- a/README.md
+++ b/README.md
@@ -140,6 +140,9 @@ There are CMake presets to cover the most frequent use cases.
 * `testing`: for building and executing the unit tests. Also the internal library symbols are exposed. Do not use for distribution.
 * `fuzzing`: similar to `testing`, this builds the fuzzers. The library should not distributed.
 
+Please note that the `default` preset mirrors the default options set in the CMakeLists.txt file. 
+This means that running `cmake --presets=default ..` is essentially equivalent to running `cmake ..` without using any presets.
+
 You can optionally adapt these standard configurations to your needs.
 This can be done, for example, by calling `ccmake .` from within the `build` directory.