implemented template and catalog syntax #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etolstoy
approved these changes
Dec 20, 2016
| @@ -0,0 +1,29 @@ | |||
| module Generamba | |||
| module Error | |||
| class Standard < StandardError; end | |||
There was a problem hiding this comment.
Why do you need this subclass?
There was a problem hiding this comment.
sorry. it's really not necessary. fixed
| @@ -0,0 +1,51 @@ | |||
| module Generamba | |||
| module Service | |||
| class RemotePlugin | |||
There was a problem hiding this comment.
I really need comments for classes and methods, otherwise I can't understand the purpose of some classes :)
There was a problem hiding this comment.
I see now that it's a generic class for any type of plugin installed from a remote repository. And catalog is a plugin too.
However it'd be great if you'll add comments for new classes. Or maybe a brief description for a pull request with some implementation details.
There was a problem hiding this comment.
I think, it`s good idea for new service classes. Done
paa001
force-pushed
the
feature/task-178
branch
from
84f8fc2
to
822d24b
Compare
|
can i merge this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#178 issue