Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add filter by ETH token #192

Open
akiraonstarknet opened this issue Dec 9, 2024 · 31 comments · May be fixed by #196
Open

feat: Add filter by ETH token #192

akiraonstarknet opened this issue Dec 9, 2024 · 31 comments · May be fixed by #196
Assignees
Labels
enhancement New feature or request medium ODHack11

Comments

@akiraonstarknet
Copy link
Contributor

We currently support filters of Stable and STRK pools. Add new filter to filter pools by ETH.
image

Suggested approach:

  1. Modify PoolInfo.category to be an array (Category[]) in pools.ts
  2. Add ETH as new Category in Category enum in pools.ts
  3. Modify project store (e.g. strkfarm.store.ts) for all projects listed to maintain pool category as ETH for ETH pools
  4. If a pool is single token pool of ETH or ETH based, it should have a ETH category in it.
  5. On the home page, find yields tab, there should be new filter called ETH pools besides STRK pools and on clicking this pool, it should filter and show just ETH pools.
@0xdevcollins
Copy link

is this issue available for contributions? @akiraonstarknet

@vestor-dev
Copy link

May I try my hand at this?

@blessingbytes
Copy link

pls , i would love to tackle this issue

@Ayoazeez26
Copy link
Contributor

Ayoazeez26 commented Dec 12, 2024

  • I will modify the PoolInfo.category in pools.ts to be an array
  • I will add ETH as a new category in the Category Enum then head to the project store to maintain pool category as ETH for ETH pools.
  • I will ensure that if a pool is a single token pool of ETH or ETH based, it will have the ETH category in it
  • I will also add a new filter called ETH pools besides STRK pools in the yields tab, and clicking on the pool should filter and show just ETH pools.
  • I will test this functionality works as intended before making a PR.

ETA - 2 days.

@CollinsC1O
Copy link

May I take care of this?

@abdegenius
Copy link
Contributor

I’d like to help with this.

@wheval
Copy link

wheval commented Dec 12, 2024

Hello @akiraonstarknet, Can i work on this?

I'm an experienced Frontend Developer.
I would enhance the current implentation to support filtering for ETH pool.
I would test it to enusre it works properly.

ETA is 2 days.

@PoulavBhowmick03
Copy link

PoulavBhowmick03 commented Dec 12, 2024

Gm, I would love to work on this
I am Poulav, an active contributor the the Starknet ecosystem, with a good experience in TS, Cairo, Rust. I have also contributed actively to the Starknet ecosystem OnlyDust
I will be going through the files and specifically pools.ts, and will make the required changes, by adding ETH as a new Category and modifying PoolInfo.category
Next I will be modifying the project stores and finally add a new filter called ETH pools beside STRK pools

ETA- 1 day

@Supa-mega
Copy link

Could I grab this task?

@jedstroke
Copy link

I’d love to work on this task.

@ncoquelet
Copy link

Hey,

I'm a dev with 20 years of XP, super comfy with TypeScript, React/Next, Dapps, Prisma, CI/CD. I ship fast and high-quality stuff. Worked with AFK and GoStarkMe, check my GitHub profile for more details (got several hackathon prizes).
Currently doing Basecamp 11.

Can I contribute to this one?

@Gerson2102
Copy link


Hey! I'm Gerson. 👋

Member of Dojo Coding. I have contributed before to other projects like:

  • kakarot-rpc
  • kakarot-ssj
  • ef-tests
  • Raito
  • Starknet-Phone
  • Madara
  • stark-cairo-nodes

This will be one of my first front-end issues. Really good opportunity to learn new things.

Check my OnlyDust profile, I've contributed to many projects: Profile


Plan to Solve the Issue:

  1. Study the codebase to understand the current structure and functionality.
  2. Understand the problem that needs to be solved by thoroughly reading the issue details.
  3. Leverage all provided resources within the issue to get a better grasp of the task at hand.
  4. If I encounter roadblocks, I will ask questions ASAP in the Telegram group to move forward effectively.
  5. I will open a PR and wait for ur feedback

@Ugo-X
Copy link
Contributor

Ugo-X commented Dec 12, 2024

Hello Chief. My name is Ugo-x, an experienced fullstack developer with over 80 contribuitons on OD, and an experience on solving issues of this nature, and I would like to handle this issue.

To handle this issue:
I will add an ETH pool filter by:

  1. Updating pool categories to support ETH
  2. Modifying project stores to categorize ETH pools
  3. Adding a new "ETH pools" filter on the home page yields tab
  4. Implementing filtering logic for ETH pools

@mimisavage
Copy link

I'd love to work on this!

@akintewe
Copy link

Hey i am oluwasola,

I'm experienced with TypeScript, React/Next, CI/CD. Worked with AFK and GoStarkMe,
I would also love to work on this task, my ETA is 12 hours. Thanks :)

@No-bodyq
Copy link

Can I try solving this issue?

@ryzen-xp
Copy link

Hi, I am a proficient blockchain developer, expert in Cairo, Rust, Solidity, Aptos, and web development. I have contributed to projects like Chainevents and Arkprojects.

I can implement the new filter to support ETH pools, including modifying the PoolInfo.category, updating the Category enum, and ensuring the front-end displays the correct ETH filter. Please assign this issue to me.

Thank you!

@martinvibes
Copy link
Contributor

i'm a frontend dev and blockchain dev
i would love to work on this and get it done
I’m interested in this one.
kindly assign

@akintewe
Copy link

Hey i am oluwasola,
I'm super comfy with TypeScript, React/Next, CI/CD. Worked with AFK and GoStarkMe, I would love to work on this issue
Can I contribute to this one? ETA 12 hours

@BrunoAmbricca
Copy link

I would like to work on this issue

@ShantelPeters
Copy link

May I handle this issue?

@Amarjeet325
Copy link

Could I take over this issue?

@Villarley
Copy link

Hi 👋🏻,
I’m Santiago Villarreal Arley, a proactive and communicative developer with experience in both front-end and back-end Web3 development. I’m a proud member of Dojo Coding and have worked on various projects built on StarkNet and Stellar, where I actively contributed to creating scalable and efficient solutions. I also won a Web3 hackathon Buildathon for my work on BuildMyEvent, an open-source blockchain project focused on solving real-world challenges and integrating useful features.

Additionally, I’m a Gold Contributor with over 15 merged PRs, showcasing my commitment to open-source development and collaborative problem-solving.

To tackle this issue:

Modify PoolInfo.category in pools.ts to be an array (Category[]), enabling support for multiple categories per pool.
Add a new category ETH to the Category enum in pools.ts.
Update the project store (e.g., strkfarm.store.ts) to ensure ETH pools maintain the ETH category.
Ensure single-token ETH or ETH-based pools have the ETH category assigned.
Update the home page yields tab by adding a new filter called ETH Pools beside the STRK pools. Configure the filter to display only pools categorized as ETH. Test to ensure the functionality is seamless.

@Jagadeeshftw
Copy link

Hello, I’d love to work on this issue as I have strong experience in developing secure and efficient smart contracts using Cairo and deploying them on StarkNet. Please assign this to me, and I’ll ensure to deliver a robust and high-quality PR within 12-24 hours.

@PedroCo3lho
Copy link

Can I work on this?
I’m a full-stack developer with a solid understanding of TypeScript, Next.js, and TailwindCSS. The requirements and development flow are clear to me. I’m looking forward to your approval and would love to work on this issue.
Please let me know if I can start so I can deliver it asap!

@Benjtalkshow
Copy link
Contributor

I am a Full Stack Developer with a strong background in blockchain and extensive experience in Next.js/React, TypeScript, and Rust. I’ve made over 49 contributions to over 17 projects in the OnlyDust ecosystem, solving complex issues and delivering efficient, scalable solutions.

I can handle this task.
ETA is 3days.

@DuendexCR
Copy link

Could I be assigned to this?

@tosinmoses384
Copy link

Can I take this from here?

@ekumamatthew
Copy link

Can I contribute to this one?

@olisaagbafor
Copy link

Can I attempt this issue?

1 similar comment
@Dorcas18
Copy link

Can I attempt this issue?

@Gerson2102 Gerson2102 linked a pull request Dec 14, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request medium ODHack11
Projects
None yet
Development

Successfully merging a pull request may close this issue.