Adding v1 of the new ETH filter for pools #196

Gerson2102 · 2024-12-14T05:14:21Z

PR Fixes:

Adding version 1 of the ETH pool filter. This PR is ready for review.

Resolves #192

Vercel website link

https://starkfarm-client-git-eth-filter-gersons-projects-b3389356.vercel.app/

Checklist before requesting a review

I have performed a self-review of my code
I assure there is no similar/duplicate pull request regarding same issue
My PR passes all checks (build, lint, formatting, etc)

Gerson2102 · 2024-12-15T04:16:56Z

I dont know how to create the vercel link needed in the PR. I deleted the initial messages of the PRs description.

EjembiEmmanuel · 2024-12-16T08:38:31Z

I dont know how to create the vercel link needed in the PR. I deleted the initial messages of the PRs description.

Create a Vercel account if you don't already have one.
Log in to Vercel and deploy the app from your forked repository.
Configure all necessary environment variables during deployment.
Include the link to your Vercel deployment in the Pull Request (PR) description.

Gerson2102 · 2024-12-16T23:23:46Z

I'm banned and I dont know why, I just posted an error that I'm facing in Vercel while deploying the app. @EjembiEmmanuel @akiraonstarknet

I'm trying to deploy mi forked version of starkfarm, and I'm getting this error:

at async eV.getTVL (/vercel/path0/.next/server/chunks/951.js:24:88440)
at async y (/vercel/path0/.next/server/app/api/strategies/route.js:1:1385)
at async Promise.all (index 5)
at async q (/vercel/path0/.next/server/app/api/strategies/route.js:1:2248)
at async /vercel/path0/node_modules/next/dist/compiled/next-server/app-route.runtime.prod.js:6:42484
at async eI.execute (/vercel/path0/node_modules/next/dist/compiled/next-server/app-route.runtime.prod.js:6:32486)
at async eI.handle (/vercel/path0/node_modules/next/dist/compiled/next-server/app-route.runtime.prod.js:6:43737)

Error occurred prerendering page "/api/strategies". Read more: https://nextjs.org/docs/messages/prerender-error

EjembiEmmanuel · 2024-12-17T07:30:28Z

I'm banned and I dont know why, I just posted an error that I'm facing in Vercel while deploying the app. @EjembiEmmanuel @akiraonstarknet

I'm trying to deploy mi forked version of starkfarm, and I'm getting this error:
at async eV.getTVL (/vercel/path0/.next/server/chunks/951.js:24:88440)
at async y (/vercel/path0/.next/server/app/api/strategies/route.js:1:1385)
at async Promise.all (index 5)
at async q (/vercel/path0/.next/server/app/api/strategies/route.js:1:2248)
at async /vercel/path0/node_modules/next/dist/compiled/next-server/app-route.runtime.prod.js:6:42484
at async eI.execute (/vercel/path0/node_modules/next/dist/compiled/next-server/app-route.runtime.prod.js:6:32486)
at async eI.handle (/vercel/path0/node_modules/next/dist/compiled/next-server/app-route.runtime.prod.js:6:43737)
Error occurred prerendering page "/api/strategies". Read more: https://nextjs.org/docs/messages/prerender-error

Does the project build locally without errors? If yes, then it might be that you didn't configure the environment variables correctly.

EjembiEmmanuel · 2024-12-17T07:35:53Z

@Gerson2102 make sure you set the following env variables

NEXT_PUBLIC_OG_NFT_CONTRACT=0x3cb654f2f557a7f71a0c16d97c05a2dec62a0b744979d11afc95b804e1d7307
ACCOUNT_PK=0x0574ba4998dd9aedf1c4d6e56b747b29256a795bc3846437d121cd64b972bdd8
RPC_URL=https://starknet-mainnet.public.blastapi.io
NEXT_PUBLIC_RPC_URL=https://starknet-mainnet.public.blastapi.io

Gerson2102 · 2024-12-17T16:49:44Z

I'm getting three errors locally: @EjembiEmmanuel

Gerson2102 · 2024-12-17T16:50:45Z

These are my env variables:

NEXT_PUBLIC_RPC_URL=https://starknet-mainnet.public.blastapi.io
RPC_URL=https://starknet-mainnet.public.blastapi.io
HOSTNAME=http://localhost:3000

DATABASE_URL=

ACCOUNT_PK=0x0574ba4998dd9aedf1c4d6e56b747b29256a795bc3846437d121cd64b972bdd8
NEXT_PUBLIC_OG_NFT_CONTRACT=0x3cb654f2f557a7f71a0c16d97c05a2dec62a0b744979d11afc95b804e1d7307

CRON_SECRET=

NEXT_PUBLIC_NETWORK=mainnet

EjembiEmmanuel · 2024-12-17T16:56:52Z

These are my env variables:

NEXT_PUBLIC_RPC_URL=https://starknet-mainnet.public.blastapi.io
RPC_URL=https://starknet-mainnet.public.blastapi.io
HOSTNAME=http://localhost:3000

DATABASE_URL=

ACCOUNT_PK=0x0574ba4998dd9aedf1c4d6e56b747b29256a795bc3846437d121cd64b972bdd8
NEXT_PUBLIC_OG_NFT_CONTRACT=0x3cb654f2f557a7f71a0c16d97c05a2dec62a0b744979d11afc95b804e1d7307

CRON_SECRET=

NEXT_PUBLIC_NETWORK=mainnet

You don't need to set the HOSTNAME when deploying on vercel

EjembiEmmanuel · 2024-12-17T17:02:08Z

I'm getting three errors locally: @EjembiEmmanuel

I will check and revert

Gerson2102 · 2024-12-17T17:17:42Z

These are my env variables:
NEXT_PUBLIC_RPC_URL=https://starknet-mainnet.public.blastapi.io
RPC_URL=https://starknet-mainnet.public.blastapi.io
HOSTNAME=http://localhost:3000
DATABASE_URL=
ACCOUNT_PK=0x0574ba4998dd9aedf1c4d6e56b747b29256a795bc3846437d121cd64b972bdd8
NEXT_PUBLIC_OG_NFT_CONTRACT=0x3cb654f2f557a7f71a0c16d97c05a2dec62a0b744979d11afc95b804e1d7307
CRON_SECRET=
NEXT_PUBLIC_NETWORK=mainnet

You don't need to set the HOSTNAME when deploying on vercel

Yeah, I was sharing my local env variables. The env variables for vercel are the ones that you told me.

EjembiEmmanuel · 2024-12-17T17:19:45Z

These are my env variables:
NEXT_PUBLIC_RPC_URL=https://starknet-mainnet.public.blastapi.io
RPC_URL=https://starknet-mainnet.public.blastapi.io
HOSTNAME=http://localhost:3000
DATABASE_URL=
ACCOUNT_PK=0x0574ba4998dd9aedf1c4d6e56b747b29256a795bc3846437d121cd64b972bdd8
NEXT_PUBLIC_OG_NFT_CONTRACT=0x3cb654f2f557a7f71a0c16d97c05a2dec62a0b744979d11afc95b804e1d7307
CRON_SECRET=
NEXT_PUBLIC_NETWORK=mainnet

You don't need to set the HOSTNAME when deploying on vercel

Yeah, I was sharing my local env variables. The env variables for vercel are the ones that you told me.

Oh okay

akiraonstarknet · 2024-12-19T07:02:06Z

NEXT_PUBLIC_OG_NFT_CONTRACT=0x3cb654f2f557a7f71a0c16d97c05a2dec62a0b744979d11afc95b804e1d7307

ACCOUNT_PK=0x0574ba4998dd9aedf1c4d6e56b747b29256a795bc3846437d121cd64b972bdd8

RPC_URL=https://starknet-mainnet.public.blastapi.io

NEXT_PUBLIC_RPC_URL=https://starknet-mainnet.public.blastapi.io

@EjembiEmmanuel can we add this to our .env.sample? Raise a new and PR for this. Also add necessary comments for variables on how people can get them which are not publicly availble.

EjembiEmmanuel · 2024-12-19T07:25:27Z

NEXT_PUBLIC_OG_NFT_CONTRACT=0x3cb654f2f557a7f71a0c16d97c05a2dec62a0b744979d11afc95b804e1d7307

ACCOUNT_PK=0x0574ba4998dd9aedf1c4d6e56b747b29256a795bc3846437d121cd64b972bdd8

RPC_URL=https://starknet-mainnet.public.blastapi.io

NEXT_PUBLIC_RPC_URL=https://starknet-mainnet.public.blastapi.io

@EjembiEmmanuel can we add this to our .env.sample? Raise a new and PR for this. Also add necessary comments for variables on how people can get them which are not publicly availble.

Alright

EjembiEmmanuel · 2024-12-19T10:41:16Z

@Gerson2102 I just pushed a minor fix. Can you try deploying on vercel again?

Gerson2102 · 2024-12-19T16:28:05Z

@EjembiEmmanuel
Here is the deployed app: https://starkfarm-client-steel.vercel.app/

CI is failing but dont understand why. Locally is not working either.

EjembiEmmanuel · 2024-12-19T17:01:38Z

@EjembiEmmanuel
Here is the deployed app: https://starkfarm-client-steel.vercel.app/

This url is for your private deployment. Please share the public url instead

Gerson2102 · 2024-12-19T18:43:03Z

Got it. Check this one: https://starkfarm-client-git-eth-filter-gersons-projects-b3389356.vercel.app/?vercelToolbarCode=FcD9vbA8h1rSocV

EjembiEmmanuel · 2024-12-20T08:57:11Z

Got it. Check this one: https://starkfarm-client-git-eth-filter-gersons-projects-b3389356.vercel.app/?vercelToolbarCode=FcD9vbA8h1rSocV

It's the same thing

Gerson2102 · 2024-12-20T14:01:06Z

Got it. Check this one: https://starkfarm-client-git-eth-filter-gersons-projects-b3389356.vercel.app/?vercelToolbarCode=FcD9vbA8h1rSocV

It's the same thing

Can you explain how to do that? Don't you think is easier?

Gerson2102 · 2024-12-20T14:02:13Z

This is what I have:

And none of those links works for you. So which link am I supposed to share with you to finally see that my work is done since days ago?

Gerson2102 · 2024-12-20T14:03:21Z

Try this one: https://starkfarm-client-steel.vercel.app

EjembiEmmanuel · 2024-12-20T15:01:18Z

Try this one: https://starkfarm-client-steel.vercel.app

Still doesn't work. Maybe try deleting the deployment and creating a new one

Gerson2102 · 2024-12-20T15:32:50Z

Try this one: https://starkfarm-client-steel.vercel.app

Still doesn't work. Maybe try deleting the deployment and creating a new one

Gerson2102 · 2024-12-20T15:33:37Z

@EjembiEmmanuel I closed it but it was a mistake.

Gerson2102 · 2024-12-20T15:34:51Z

This is the only link that I can share: https://starkfarm-client-steel.vercel.app/
Maybe this one: https://starkfarm-client-f0k22bc11-gersons-projects-b3389356.vercel.app/

EjembiEmmanuel · 2024-12-20T15:36:34Z

@EjembiEmmanuel Here is the deployed app: https://starkfarm-client-steel.vercel.app/

CI is failing but dont understand why. Locally is not working either.

The CI is failing because of unsuccessful RPC calls, it could be that the CI is using the RPC url for sepolia instead of mainnet. Try to create a RPC_URL secret variable with this value https://starknet-mainnet.public.blastapi.io in the settings of your fork. Let me know when you do it so that I can rerun the CI.

EjembiEmmanuel · 2024-12-20T15:43:13Z

This is the only link that I can share: https://starkfarm-client-steel.vercel.app/ Maybe this one: https://starkfarm-client-f0k22bc11-gersons-projects-b3389356.vercel.app/

Yea, that's why I said you should delete the current deployment and create a new one. Maybe it'll fix it

Gerson2102 · 2024-12-20T15:44:36Z

Got it. Run the CI now please.

EjembiEmmanuel · 2024-12-20T15:50:20Z

Got it. Run the CI now please.

Still failing. How did you set the create variable?

Gerson2102 · 2024-12-20T15:50:51Z

https://starkfarm-client-i61s9uaww-gersons-projects-b3389356.vercel.app/

Gerson2102 · 2024-12-20T15:51:30Z

Got it. Run the CI now please.

Still failing. How did you set the create variable?

Just like you said. I went to my fork and create a secret variable. RPC_URL and then the value.

Gerson2102 · 2024-12-20T15:54:25Z

The CI is failing because there is errors on these paths:

/api/stats/route: /api/stats
/api/strategies/route: /api/strategies

But there is nothing wrong when I check the code in my IDE

EjembiEmmanuel · 2024-12-20T15:59:18Z

The CI is failing because there is errors on these paths:

/api/stats/route: /api/stats /api/strategies/route: /api/strategies

But there is nothing wrong when I check the code in my IDE

The error is not coming from the code, the code is fine

EjembiEmmanuel · 2024-12-20T15:59:58Z

Got it. Run the CI now please.

Still failing. How did you set the create variable?

Just like you said. I to went my fork and create a secret variable. RPC_URL and then the value.

Alright then, just ignore it for now

Gerson2102 · 2024-12-20T17:10:29Z

The eth filter is working fine.

akiraonstarknet · 2024-12-23T09:27:15Z

src/store/carmine.store.ts

@@ -48,14 +48,14 @@ export class Carmine extends Jediswap {
        const poolData = myData[config.name];
        if (!poolData || !poolData.data) return;

-        let category: Category;
+        const category: Category[] = [Category.Others];


Dont think having others as default for everything makes sense.

Others is only for something that doesn't wallet in one of the known categories.

Got it. So I'm going to just defined the variable and thats it. @akiraonstarknet

akiraonstarknet · 2024-12-23T09:28:04Z

src/store/pools.ts

@@ -77,7 +78,7 @@ export function getDefaultPoolInfo(): PoolInfo {
    apr: 0,
    tvl: 0,
    aprSplits: [],
-    category: Category.Others,
+    category: [Category.Others],


Need to validate this. @EjembiEmmanuel

Gerson2102 added 3 commits December 13, 2024 23:10

Adding v1 of the new ETH filter for pools

f56b569

Adding all the ETH filters in stores

739b6b3

Changing new way of adding protocol in docs file

f2d34b5

Gerson2102 marked this pull request as ready for review December 14, 2024 17:40

fix: fix eligible pools filter

002d70a

Gerson2102 closed this Dec 20, 2024

Gerson2102 reopened this Dec 20, 2024

akiraonstarknet requested a review from EjembiEmmanuel December 23, 2024 08:52

akiraonstarknet requested changes Dec 23, 2024

View reviewed changes

Addressing PR comment related to defining the others category

358dcbc

Adding v1 of the new ETH filter for pools #196

Are you sure you want to change the base?

Adding v1 of the new ETH filter for pools #196

Conversation

Gerson2102 commented Dec 14, 2024 • edited Loading

PR Fixes:

Vercel website link

Checklist before requesting a review

Gerson2102 commented Dec 15, 2024

EjembiEmmanuel commented Dec 16, 2024

Gerson2102 commented Dec 16, 2024 • edited Loading

EjembiEmmanuel commented Dec 17, 2024

EjembiEmmanuel commented Dec 17, 2024

Gerson2102 commented Dec 17, 2024

Gerson2102 commented Dec 17, 2024 • edited Loading

EjembiEmmanuel commented Dec 17, 2024

EjembiEmmanuel commented Dec 17, 2024

Gerson2102 commented Dec 17, 2024

EjembiEmmanuel commented Dec 17, 2024

akiraonstarknet commented Dec 19, 2024 • edited Loading

EjembiEmmanuel commented Dec 19, 2024

EjembiEmmanuel commented Dec 19, 2024

Gerson2102 commented Dec 19, 2024 • edited Loading

EjembiEmmanuel commented Dec 19, 2024

Gerson2102 commented Dec 19, 2024

EjembiEmmanuel commented Dec 20, 2024

Gerson2102 commented Dec 20, 2024

Gerson2102 commented Dec 20, 2024 • edited Loading

Gerson2102 commented Dec 20, 2024

EjembiEmmanuel commented Dec 20, 2024

Gerson2102 commented Dec 20, 2024

Gerson2102 commented Dec 20, 2024 • edited Loading

Gerson2102 commented Dec 20, 2024 • edited Loading

EjembiEmmanuel commented Dec 20, 2024

EjembiEmmanuel commented Dec 20, 2024

Gerson2102 commented Dec 20, 2024

EjembiEmmanuel commented Dec 20, 2024

Gerson2102 commented Dec 20, 2024

Gerson2102 commented Dec 20, 2024 • edited Loading

Gerson2102 commented Dec 20, 2024

EjembiEmmanuel commented Dec 20, 2024

EjembiEmmanuel commented Dec 20, 2024

Gerson2102 commented Dec 20, 2024

akiraonstarknet Dec 23, 2024

Choose a reason for hiding this comment

akiraonstarknet Dec 23, 2024

Choose a reason for hiding this comment

Gerson2102 Dec 23, 2024

Choose a reason for hiding this comment

akiraonstarknet Dec 23, 2024

Choose a reason for hiding this comment

Gerson2102 commented Dec 14, 2024 •

edited

Loading

Gerson2102 commented Dec 16, 2024 •

edited

Loading

Gerson2102 commented Dec 17, 2024 •

edited

Loading

akiraonstarknet commented Dec 19, 2024 •

edited

Loading

Gerson2102 commented Dec 19, 2024 •

edited

Loading

Gerson2102 commented Dec 20, 2024 •

edited

Loading

Gerson2102 commented Dec 20, 2024 •

edited

Loading

Gerson2102 commented Dec 20, 2024 •

edited

Loading

Gerson2102 commented Dec 20, 2024 •

edited

Loading