Skip to content
This repository has been archived by the owner on Apr 1, 2024. It is now read-only.

ISSUE-20772: [improve][broker] Add metrics related interfaces for BrokerInterceptor #5833

Open
2 tasks done
streamnativebot opened this issue Jul 19, 2023 · 0 comments
Open
2 tasks done

Comments

@streamnativebot
Copy link

url: apache#20772

Search before asking

  • I searched in the issues and found nothing similar.

Motivation

When I want to monitor the relevant data in the BrokerInterceptor, currently the BrokerInterceptor does not provide relevant interfaces.

I think providing such extensions is necessary.

Solution

https://github.com/apache/pulsar/blob/e96b3398912163eb6e0528c10aed3507c95952fd/pulsar-broker/src/main/java/org/apache/pulsar/broker/intercept/BrokerInterceptor.java

Add a interface, like this:

default void addCustomizeMetrics(PrometheusMetricStreams streams, PulsarService pulsar){
}

https://github.com/apache/pulsar/blob/e96b3398912163eb6e0528c10aed3507c95952fd/pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/PrometheusMetricsGenerator.java#L185-L187

Then callback the addCustomizeMetrics(stream, pulsar) method here.

This is just a draft.

Alternatives

No response

Anything else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant