Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewing own Directory Profile shows multiple markers #87

Open
3 tasks done
andrewlimaza opened this issue Jan 17, 2025 · 0 comments
Open
3 tasks done

Viewing own Directory Profile shows multiple markers #87

andrewlimaza opened this issue Jan 17, 2025 · 0 comments
Labels
Good First Bug Issues specifically for first time contributors. Next actions should be clear. The team will help.

Comments

@andrewlimaza
Copy link
Collaborator

andrewlimaza commented Jan 17, 2025

Describe the bug
When viewing your own profile from the Membership Directory, it shows all map markers and not just your own like if you were viewing another person's profile.

This is because the profile is missing the username from the path.

Broken: /membership-account/profile
Working: /membership-account/profile/myusername

To Reproduce
Steps to reproduce the behavior:

  1. Go to xxx/membership-account/profile
  2. See that multiple markers are shown.
  3. Go to your own username profile from the Membership Directory, xxx/membership-account/profile/myusername
  4. See that it's fixed.

See error when viewing your own profile without the username as part of the URL:

Image

Expected behavior
Fix this issue when viewing your own profile if the username is missing. Fallback to the current user if logged-in. See around here - https://github.com/strangerstudios/pmpro-membership-maps/blob/dev/pmpro-membership-maps.php#L666

Isolating the problem (mark completed items with an [x]):

  • I have deactivated other plugins and confirmed this bug occurs when only Paid Memberships Pro plugin is active.
  • This bug happens with a default WordPress theme active, or Memberlite.
  • I can reproduce this bug consistently using the steps above.
@andrewlimaza andrewlimaza added the Good First Bug Issues specifically for first time contributors. Next actions should be clear. The team will help. label Jan 17, 2025
MaximilianoRicoTabo added a commit to MaximilianoRicoTabo/pmpro-membership-maps that referenced this issue Jan 17, 2025
…ngerstudios#87

 * tweak pmpromm_load_profile_map_marker function to narrow sql select whene PU isn't passed in the URL.
MaximilianoRicoTabo added a commit to MaximilianoRicoTabo/pmpro-membership-maps that referenced this issue Jan 17, 2025
…ngerstudios#87

 * tweak pmpromm_load_profile_map_marker function to narrow sql select whene PU isn't passed in the URL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Bug Issues specifically for first time contributors. Next actions should be clear. The team will help.
Projects
None yet
Development

No branches or pull requests

1 participant